Listing 5 projects on Welcome page
I think there is an issue on the welcome.rhtml page when the code lists all the projects:
<% for project in @projects >
<= link_to project.name, :controller => 'projects', :action => 'show', :id => project > (<=
format_time(project.created_on) >)<br />
<=h project.description >
< end %>
Or, perhaps more importantly in the welcome_controller.rb:
@news = News.latest
@projects = Project.latest
Reason: If a user clicks on a non-public project where he is not a member, they will receive a blank page (error).
Perhaps it will be better not to see private projects where the user is not a member?
As a potential solution, let's update the Project.latest method to return 5 projects where logged_in_user is a member
or the project is public?
What do you think?
Commit messages are now scanned for referenced or fixed issue IDs.
Keywords and the status to apply to fixed issues can be defined in Admin -> Settings.
- for referencing issues: refs, references, IssueID
- for fixing issues: fixes,closes
There's no default status defined for fixed issue. You'll have to specify it if you want to enable auto closure of issues.
#1 Updated by Jean-Philippe Lang almost 11 years ago
Happy new year Todd !
I've corrected this bug, with a slight different solution (your
code was good but i prefer not to add a join).
I've modified "Latest news" too so that they are displayed
according to user's membership.
Just a thing about your code: don't forget that logged_in_user
can be nil (if nobody's logged).
#2 Updated by Todd McGrath almost 11 years ago
I'll attach two patch files that solved it
(project.rb-PATCH.txt and welcome_controller.rb-PATCH.txt).
What do you think? (I'm coming from Java and trying to
learn more Ruby/Rails. I'm not very confident in Ruby yet
and appreciate any feedback)