Defect #20551

Typo "coma" (correct: "comma")

Added by Toshi MARUYAMA almost 3 years ago. Updated almost 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Code cleanup/refactoring
Target version:3.2.0
Resolution:Fixed Affected version:

Description

On trunk r14506:

1. label_coma_char

Introduced by r14494 (#950):

./config/locales/en.yml-963-  label_fields_separator: Field separator
./config/locales/en.yml-964-  label_fields_wrapper: Field wrapper
./config/locales/en.yml-965-  label_encoding: Encoding
./config/locales/en.yml:966:  label_coma_char: Coma
./config/locales/en.yml-967-  label_semi_colon_char: Semi colon
./config/locales/en.yml-968-  label_quote_char: Quote
./config/locales/en.yml-969-  label_double_quote_char: Double quote

2. :lastname_coma_firstname

./app/models/user.rb-47-        :order => %w(lastname firstname id),
./app/models/user.rb-48-        :setting_order => 4
./app/models/user.rb-49-      },
./app/models/user.rb:50:    :lastname_coma_firstname => {
./app/models/user.rb-51-        :string => '#{lastname}, #{firstname}',
./app/models/user.rb-52-        :order => %w(lastname firstname id),
./app/models/user.rb-53-        :setting_order => 5

3. lib/redmine/wiki_formatting/macros.rb

./lib/redmine/wiki_formatting/macros.rb-92-        #   invoked without a block of text.  
./lib/redmine/wiki_formatting/macros.rb-93-        #
./lib/redmine/wiki_formatting/macros.rb-94-        # Examples:
./lib/redmine/wiki_formatting/macros.rb:95:        # By default, when the macro is invoked, the coma separated list of arguments
./lib/redmine/wiki_formatting/macros.rb-96-        # is split and passed to the macro block as an array. If no argument is given
./lib/redmine/wiki_formatting/macros.rb-97-        # the macro will be invoked with an empty array:
./lib/redmine/wiki_formatting/macros.rb-98-        #

redmine-20551_CommaTypo.patch Magnifier (26.8 KB) budo kaiman, 2015-10-20 18:36


Related issues

Related to Redmine - Feature #950: Import Issues from delimited/CSV file Closed 2008-03-29

Associated revisions

Revision 14712
Added by Jean-Philippe Lang almost 3 years ago

Typo "coma" (#20551).

Patch by budo kaiman.

Revision 14713
Added by Jean-Philippe Lang almost 3 years ago

Fix setting value if used (#20551).

History

#1 Updated by Toshi MARUYAMA almost 3 years ago

  • Description updated (diff)

#2 Updated by Toshi MARUYAMA almost 3 years ago

  • Related to Feature #950: Import Issues from delimited/CSV file added

#3 Updated by Jean-Philippe Lang almost 3 years ago

  • Target version set to 3.2.0

#4 Updated by budo kaiman almost 3 years ago

I've attached a patch that will fix all of these typos.

#5 Updated by Jean-Philippe Lang almost 3 years ago

  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Patch committed in r14712, thanks. I've also added a migration to fix the setting value for those who use the fixed value.

Also available in: Atom PDF