Defect #2122

URL in send_reminders email for 'View all issues' is incorrect.

Added by Robert Chady almost 9 years ago. Updated almost 9 years ago.

Status:ClosedStart date:2008-11-01
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Email notifications
Target version:0.8
Resolution:Fixed Affected version:0.7.3

Description

In the emails send_reminder sends out, the URL inserted for the 'View all issues' link is not correct if you have the project installed in a sub-directory. All other URLs that get sent out are correct, just not this one. This is based on r1646 so it is a ways behind trunk, but it looks to do the same thing in HEAD too.

Associated revisions

Revision 1989
Added by Jean-Philippe Lang almost 9 years ago

Host setting should contain the path prefix (Redmine base URL) to properly generate links in emails that are sent offline (#2122).

Revision 1992
Added by Jean-Philippe Lang almost 9 years ago

Do not use :skip_relative_url_root to generate urls in Mailer (#2122).

History

#1 Updated by Robert Chady almost 9 years ago

Related to this issue, I also found that emails generated from SVN commits also has the incorrect URL, namely it is missing the sub-directory in the URL: /issues/show/### instead of /redmine/issues/show/###.

On a hunch I tried to update the 'host' setting in settings to include the /redmine so url_for() will build the correct URl. Unfortunately, this results in normal email notices of activity going out with /redmine/redmine/issues/show/### in the URL.

So, why are URLs getting built one way for SVN commits and send_reminders, but another way for normal activity emails?

#2 Updated by Jean-Philippe Lang almost 9 years ago

  • Category set to Email notifications
  • Status changed from New to Resolved
  • Target version set to 0.8
  • Affected version (unused) set to 0.7.3
  • Resolution set to Fixed
  • Affected version set to 0.7.3

This should be fixed in r1989. Add /redmine to your host setting, it should no longer be added twice to the url when sending emails from the web app.

Feedback is welcome.

#3 Updated by Eric Davis almost 9 years ago

  • Status changed from Resolved to 7
  • Resolution deleted (Fixed)

r1989 caused a test failure because :skip_relative_url_root is added to the url, "https://mydomain.foo/issues/show/1?skip_relative_url_root=true". Is the :skip_relative_url_root option available in mailer views?

#4 Updated by Jean-Philippe Lang almost 9 years ago

  • Status changed from 7 to Closed
  • Resolution set to Fixed

Indeed. UrlRewriter#url_for doesn't work as I expected.
r1992 should fix it.

Also available in: Atom PDF