Defect #24308: Allow Journal to return empty Array instead nil in Journal#attachments - Redmine

Actions

Copy link

Defect #24308

closed

Allow Journal to return empty Array instead nil in Journal#attachments

Added by Roman Shipiev over 7 years ago. Updated over 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Attachments

Target version:

3.4.0

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Description

If we journalize objects without #attachments then take exception (TypeError: no implicit conversion of nil into Array) in app/helpers/application_helper.rb

  def parse_inline_attachments(text, project, obj, attr, only_path, options)
    ...
    attachments += obj.attachments if obj.respond_to?(:attachments)
    ...
  end