Defect #26599

Corrupted file name when exporting a wiki page with Non-ASCII title using Microsoft's browsers

Added by Go MAEDA about 1 month ago. Updated 26 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Wiki
Target version:3.3.5
Resolution:Fixed Affected version:3.3.4

Description

Steps to reproduce:

1. Create a wiki page with Non-ASCII title (e.g. "日本語").
2. Open the wiki page using Microsoft Edge or Internet Explorer.
3. Click "TXT" in "Also available in" area.
4. The page will be exported but its file name is corrupted.

screenshot

currepted-filename.png - screenshot (15.9 KB) Go MAEDA, 2017-08-01 12:52

0001-Fix-file-name-corruption-when-export-a-wiki-page-wit.patch Magnifier (1.56 KB) Go MAEDA, 2017-08-01 14:03

0002-Add-a-test-for-file-name-corruption-when-export-a-wi.patch Magnifier (1.72 KB) Go MAEDA, 2017-08-01 14:03

Associated revisions

Revision 16957
Added by Toshi MARUYAMA 26 days ago

fix file name corruption when export a wiki page with non-ASCII title in MS browsers (#26599)

Contributed by Go MAEDA.

Revision 16959
Added by Toshi MARUYAMA 26 days ago

Merged r16957 from trunk to 3.4-stable (#26599)

fix file name corruption when export a wiki page with non-ASCII title in MS browsers.

Contributed by Go MAEDA.

Revision 16960
Added by Toshi MARUYAMA 26 days ago

Merged r16957 from trunk to 3.3-stable (#26599)

fix file name corruption when export a wiki page with non-ASCII title in MS browsers.

Contributed by Go MAEDA.

History

#1 Updated by Go MAEDA about 1 month ago

  • Target version set to 3.3.5

#3 Updated by Toshi MARUYAMA about 1 month ago

If you write non ascii characters in source, you need to encode "\xnn" or add "# encoding: utf-8" header for Ruby version compatibility.

source:tags/3.3.4/test/unit/lib/redmine/i18n_test.rb#L192
source:tags/3.3.4/test/unit/helpers/application_helper_test.rb#L1

#4 Updated by Toshi MARUYAMA 26 days ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Committed in trunk, 3.4-stalbe, and 3.3-stable, thanks.

Also available in: Atom PDF