Patch #27790

mercurial - fix double quotes in branch names

Added by Alexander Ryabinovskiy 10 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:-

Description

Hello.
I have redmine 3.4.3 installation.
Redmine can`t handle mercurial branches with double quotes, it throws an error after parsing with ActiveSupport::XmlMini.parse(xml):

hg: error during getting info: undefined method `[]' for nil:NilClass

because "xml" variable contains string like this:
<branch revision=\"138\" node=\"8a17814e772e4a41b9c2480e047dce7d9181a39e\" name=\"\"TestBranch\"\"/>

My solution is to replace double quotes in branch name with

&quot;
in redminehelper.py, .patch is in attach.

redmine_redminehelper_fix.diff Magnifier (968 Bytes) Alexander Ryabinovskiy, 2017-12-13 11:55

Also available in: Atom PDF