Defect #27884
RTL wiki class broken in Redmine 3.2.6
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | Text formatting | |||
| Target version: | 3.3.7 | |||
| Resolution: | Fixed | Affected version: | 3.4.2 |
Description
The fix at #8121 is broken as stated in my last comment there.
My environment: Redmine 3.4.2, Google Chrome 63
1. `p(rtl).` maps to `class="wiki-class-rtl"` in html, but there is no such class in application.css
2. `unicode-bidi:bidi-override` must be removed or set to `normal`
See https://www.w3schools.com/cssref/pr_text_unicode-bidi.asp
Related issues
History
#1
Updated by Toshi MARUYAMA 9 months ago
- Target version set to 3.4.5
Hooman Valibeigi wrote:
The fix at #8121 is broken as stated in my last comment there.
My environment: Redmine 3.4.2, Google Chrome 63
1. `p(rtl).` maps to `class="wiki-class-rtl"` in html, but there is no such class in application.css
I think we can change like r16503.
2. `unicode-bidi:bidi-override` must be removed or set to `normal`
See https://www.w3schools.com/cssref/pr_text_unicode-bidi.asp
Which do you think is better?
#2
Updated by Hooman Valibeigi 9 months ago
Toshi MARUYAMA wrote:
Which do you think is better?
Replacing the following lines in application.xml
.ltr {direction:ltr !important; unicode-bidi:bidi-override;}
.rtl {direction:rtl !important; unicode-bidi:bidi-override;}with these, will fix it
.wiki-class-ltr {direction:ltr !important;}
.wiki-class-rtl {direction:rtl !important;}#3
Updated by Hooman Valibeigi 9 months ago
It would be more appreciated if someone documents the syntax of `p(rtl).` on the wiki
https://www.redmine.org/projects/redmine/wiki/RedmineTextFormattingTextile
#4
Updated by Toshi MARUYAMA 9 months ago
Hooman Valibeigi wrote:
Toshi MARUYAMA wrote:
Which do you think is better?
Replacing the following lines in application.xml
Do you mean application.css, not application.xml?
#5
Updated by Hooman Valibeigi 9 months ago
Toshi MARUYAMA wrote:
Do you mean application.css, not application.xml?
Yes, redmine/public/stylesheets/application.css
#6
Updated by Hooman Valibeigi 9 months ago
I've just noticed that HTML emails sent from Redmine will contain class="wiki-class-rtl" for RTL text, which is not supposed to work because email clients have no access to Redmine css.
#7
Updated by Jean-Philippe Lang 7 months ago
- Subject changed from Support RTL Bidirection text to RTL wiki class broken in Redmine 3.2.6
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Target version changed from 3.4.5 to 3.3.7
- Resolution set to Fixed
The wiki class is fixed by r17260.
I've just noticed that HTML emails sent from Redmine will contain class="wiki-class-rtl" for RTL text, which is not supposed to work because email clients have no access to Redmine css.
Please open a separate issue as this problem is not specific the .rtl class.
#8
Updated by Hooman Valibeigi 7 months ago
Jean-Philippe Lang wrote:
The wiki class is fixed by r17260.
You forgot to fix the unicode-bidi:bidi-override; value, must be unicode-bidi:normal; or left unset. bidi-override rotates the English words in a RTL context, therefore word "cat" will be seen as "tac".
#9
Updated by Hooman Valibeigi 7 months ago
- Status changed from Closed to Reopened
#10
Updated by Jean-Philippe Lang 7 months ago
- Related to Feature #8121: Allow overriding direction of part of text added
#11
Updated by Jean-Philippe Lang 7 months ago
- Status changed from Reopened to Closed
bidi-override removed in r17280.