Defect #27884: RTL wiki class broken in Redmine 3.2.6 - Redmine

Actions

Copy link

Defect #27884

closed

RTL wiki class broken in Redmine 3.2.6

Added by Hooman Valibeigi over 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Text formatting

Target version:

3.3.7

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

3.4.2

Description

The fix at #8121 is broken as stated in my last comment there.

My environment: Redmine 3.4.2, Google Chrome 63

1. `p(rtl).` maps to `class="wiki-class-rtl"` in html, but there is no such class in application.css
2. `unicode-bidi:bidi-override` must be removed or set to `normal`
See https://www.w3schools.com/cssref/pr_text_unicode-bidi.asp

Related issues

Actions

Copy link

Updated by Toshi MARUYAMA over 6 years ago

Target version set to 3.4.5

Hooman Valibeigi wrote:

The fix at #8121 is broken as stated in my last comment there.

My environment: Redmine 3.4.2, Google Chrome 63

1. `p(rtl).` maps to `class="wiki-class-rtl"` in html, but there is no such class in application.css

I think we can change like r16503.

2. `unicode-bidi:bidi-override` must be removed or set to `normal`
See https://www.w3schools.com/cssref/pr_text_unicode-bidi.asp

Which do you think is better?

Actions

Copy link

Updated by Hooman Valibeigi over 6 years ago

Toshi MARUYAMA wrote:

Which do you think is better?

Replacing the following lines in application.xml

.ltr {direction:ltr !important; unicode-bidi:bidi-override;}
.rtl {direction:rtl !important; unicode-bidi:bidi-override;}

with these, will fix it

.wiki-class-ltr {direction:ltr !important;}
.wiki-class-rtl {direction:rtl !important;}

Actions

Copy link

Updated by Hooman Valibeigi over 6 years ago

It would be more appreciated if someone documents the syntax of `p(rtl).` on the wiki
https://www.redmine.org/projects/redmine/wiki/RedmineTextFormattingTextile

Actions

Copy link

Updated by Toshi MARUYAMA over 6 years ago

Hooman Valibeigi wrote:

Toshi MARUYAMA wrote:

Which do you think is better?

Replacing the following lines in application.xml

Do you mean application.css, not application.xml?

Actions

Copy link

Updated by Hooman Valibeigi over 6 years ago

Toshi MARUYAMA wrote:

Do you mean application.css, not application.xml?

Yes, redmine/public/stylesheets/application.css

Actions

Copy link

Updated by Hooman Valibeigi about 6 years ago

I've just noticed that HTML emails sent from Redmine will contain class="wiki-class-rtl" for RTL text, which is not supposed to work because email clients have no access to Redmine css.

Actions

Copy link

Updated by Jean-Philippe Lang about 6 years ago

Subject changed from Support RTL Bidirection text to RTL wiki class broken in Redmine 3.2.6
Status changed from New to Closed
Assignee set to Jean-Philippe Lang
Target version changed from 3.4.5 to 3.3.7
Resolution set to Fixed

The wiki class is fixed by r17260.

I've just noticed that HTML emails sent from Redmine will contain class="wiki-class-rtl" for RTL text, which is not supposed to work because email clients have no access to Redmine css.

Please open a separate issue as this problem is not specific the .rtl class.

Actions

Copy link

Updated by Hooman Valibeigi about 6 years ago

Jean-Philippe Lang wrote:

The wiki class is fixed by r17260.

You forgot to fix the unicode-bidi:bidi-override; value, must be unicode-bidi:normal; or left unset. bidi-override rotates the English words in a RTL context, therefore word "cat" will be seen as "tac".

Actions

Copy link