Project

General

Profile

Actions
Copy link

Patch #31034

closed

Remove encoding magic comments

Added by Go MAEDA over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Code cleanup/refactoring
Target version:
4.1.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The magic comment "encoding: utf-8" is no longer necessary. It was necessary only in Ruby 1.9 in which default script encoding was ASCII-8BIT. The default is UTF-8 after Ruby 2.0.

Since Redmine 4.0 or later don't support Ruby 1.9 (#25538), we can remove the magic comment.

Files

remove-magic-comment.patch (25 KB) remove-magic-comment.patch Go MAEDA, 2019-03-16 06:19
Actions
Copy link
 #1

Updated by Go MAEDA over 5 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed.

Actions
Copy link
 #2

Updated by Go MAEDA over 5 years ago

  • Tracker changed from Defect to Patch
Actions
Copy link
 #3

Updated by Go MAEDA over 5 years ago

  • Subject changed from Remove the encoding magic comment to Remove encoding magic comments
Actions
Copy link

Also available in: Atom PDF