Project

General

Profile

Actions

Defect #33175

closed

Starting or ending marker is not displayed if they are on the leftmost or rightmost boundary of the gantt

Added by Yuichi HARADA over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Gantt
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

If the start date is the first day of the Gantt or the due date is the last day of the Gantt, the mark of the Gantt bar is not displayed.

expect actual

Files

expect.png (266 KB) expect.png Yuichi HARADA, 2020-03-19 04:09
actual.png (224 KB) actual.png Yuichi HARADA, 2020-03-19 04:09
33175.patch (2.59 KB) 33175.patch Yuichi HARADA, 2020-03-19 04:16
33175-r19958.patch (2.28 KB) 33175-r19958.patch Go MAEDA, 2020-08-09 09:17

Related issues

Related to Redmine - Defect #33140: Gantt bar is not displayed if the due date is the leftmost date or the start date is the rightmost dateClosedGo MAEDA

Actions
Actions #1

Updated by Yuichi HARADA over 4 years ago

Resolve with the following patch.

diff --git a/lib/redmine/helpers/gantt.rb b/lib/redmine/helpers/gantt.rb
index 285eb66a0..ad9bab8ad 100644
--- a/lib/redmine/helpers/gantt.rb
+++ b/lib/redmine/helpers/gantt.rb
@@ -624,13 +624,13 @@ module Redmine
         zoom ||= @zoom
         coords = {}
         if start_date && end_date && start_date < self.date_to && end_date > self.date_from
-          if start_date > self.date_from
+          if start_date >= self.date_from
             coords[:start] = start_date - self.date_from
             coords[:bar_start] = start_date - self.date_from
           else
             coords[:bar_start] = 0
           end
-          if end_date < self.date_to
+          if end_date <= self.date_to
             coords[:end] = end_date - self.date_from
             coords[:bar_end] = end_date - self.date_from + 1
           else
Actions #2

Updated by Go MAEDA over 4 years ago

  • Target version set to Candidate for next minor release
Actions #3

Updated by Go MAEDA about 4 years ago

Updated the patch for the latest trunk.

Actions #4

Updated by Go MAEDA about 4 years ago

  • Related to Defect #33140: Gantt bar is not displayed if the due date is the leftmost date or the start date is the rightmost date added
Actions #5

Updated by Go MAEDA about 4 years ago

  • Status changed from New to Confirmed
  • Target version changed from Candidate for next minor release to 4.0.8

Setting the target version to 4.0.8.

Actions #6

Updated by Go MAEDA about 4 years ago

  • Subject changed from Gantt bar's mark is not displayed if the start date is the first day of the Gantt to Starting or ending marker is not displayed if they are on the leftmost or rightmost boundary of the gantt
  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for your contribution.

Actions #7

Updated by Go MAEDA about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF