Actions
Patch #37748
openFavicon takes a long time to load
Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:
0%
Estimated time:
Description
I'm using passenger standalone and nginx as proxy webserver. Redmine is v5.0.2.
I've noticed that favicon isn't cached, and takes a ridiculous amount to load (~30ms).
While caching should be configured at webserver level, I've noticed that when I remove versioning from the favicon, it only takes about 4ms to load it.
This is a simple patch, maybe it would be better to remove some more of the code related to favicon, but I'm not familiar with ruby.
Before:
After:
Files
Updated by Go MAEDA over 1 year ago
The following code will also work if a third-party theme provides a favicon.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index ced1845eb..2ae3f1beb 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -1752,7 +1752,7 @@ module ApplicationHelper
# Returns the path to the favicon
def favicon_path
icon = (current_theme && current_theme.favicon?) ? current_theme.favicon_path : '/favicon.ico'
- image_path(icon)
+ asset_path(icon)
end
# Returns the full URL to the favicon
Actions