Project

General

Profile

Actions

Defect #4918

closed

Revisions r3453 and r3454 broke On-the-fly user creation with LDAP

Added by Jack Kurzecki about 14 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
LDAP
Target version:
Start date:
2010-02-23
Due date:
% Done:

100%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Revisions r3453 and r3454 broke On-the-fly user creation with LDAP

When attempting to enter a valid username and password for a user existing in AD, but not in Redmine I'm getting the following error (production.log):

Processing AccountController#login (for 192.168.0.100 at 2010-02-23 13:00:27) [POST]
  Parameters: {"back_url"=>"http%3A%2F%2Flocalhost", "action"=>"login", "authenticity_token"=>"cBCdZZoPF6hXV2QeqgVcd/BKAkYH9laBDjRKdSSSA10=", "username"=>"user1", "controller"=>"account", "password"=>"[FILTERED]", "login"=>"Login ยป"}

ActiveRecord::UnknownAttributeError (unknown attribute: dn):
  app/models/user.rb:114:in `new'
  app/models/user.rb:114:in `try_to_login'
  app/controllers/account_controller.rb:140:in `password_authentication'
  app/controllers/account_controller.rb:35:in `login'

Rendering C:/webserver/railsapps/redmine/public/500.html (500 Internal Server Error)

Reverting only app\models\auth_source_ldap.rb to r3452 fixes the issue and user gets created in Redmine.

Actions #1

Updated by Tim Perkins about 14 years ago

I'm running into this exact same issue too.

Actions #2

Updated by Jean-Philippe Lang about 14 years ago

  • Assignee set to Eric Davis
Actions #3

Updated by Eric Davis about 14 years ago

  • Status changed from New to 7

I'll fix this. It's odd that the tests didn't catch it.

Actions #4

Updated by Eric Davis about 14 years ago

  • Status changed from 7 to Closed
  • Target version set to 1.0.0 (RC)
  • % Done changed from 0 to 100
  • Resolution set to Fixed

I've fixed this in r3485 and also included the unit test that I thought existed already (it was on a client's branch only). Sorry about introducing the bug.

Actions #5

Updated by Adriano Machado almost 10 years ago

I'm working with redmine 2.5.1 and I'm getting this erros with valid accounts. Some accounts are created, but others aren't.

Actions #6

Updated by Toshi MARUYAMA almost 10 years ago

Adriano Machado wrote:

I'm working with redmine 2.5.1 and I'm getting this erros with valid accounts. Some accounts are created, but others aren't.

Do not post closed issue with target version.
Please post to forum or create issue with more details.

Actions

Also available in: Atom PDF