Defect #5452

Member role forms in project settings are not hidden after member added

Added by Yuki Kita 4 months ago. Updated 2 months ago.

Status:Closed Start:2010-05-06
Priority:Normal Due date:
Assigned to:Eric Davis % Done:

100%
Category:UI
Target version:0.9.5
Affected version:devel Resolution:Fixed

Description

Member role forms in project settings should be hidden by default.
And we click [edit] button to see them.
But if I add some member to a project, all member role forms are shown.
So I have to click [cancel] button one by one to hide them.

It seems that the behavior was changed after the fix for #4852 ( r3483 ).
Because the load event handler bellow is not called after member added.

Event.observe(window, 'load', function() {
  $$('.hol').each(function(el) {
      el.hide();
    });
});

_members.rhtml.diff (1.1 KB) Alain Alain091, 2010-05-07 23:06

application.js.diff (375 Bytes) Alain Alain091, 2010-05-07 23:07

member_role_forms.patch (3.2 KB) Yuki Kita, 2010-05-08 02:53

member_role_forms2.patch (2.8 KB) Yuki Kita, 2010-05-11 14:38

Associated revisions

Revision 3784
Added by Eric Davis 2 months ago

Hide the role forms when editing or adding Project members. #5452

Contributed by Yuki Kita

History

Updated by Felix Schäfer 4 months ago

  • Category set to UI
  • Target version set to 0.9.5

I have also had that problem on at least one of my installations. I'll try to go through all of them and post the version numbers.

Updated by Alain Alain091 4 months ago

See patches attached for application.js and _members.rhtml

The name of the function hideRoles could be change if not appropriate.

Updated by Alain Alain091 4 months ago

The other file

Updated by Yuki Kita 4 months ago

Alain Gandon wrote:

See patches attached for application.js and _members.rhtml

The name of the function hideRoles could be change if not appropriate.

Thanks for your cooperation.
The patch works fine.
But I noticed that there still remains some code to be fixed.
So I updated your patch.

Updated by Yuki Kita 4 months ago

But I noticed that there still remains some code to be fixed.

Member role forms are shown not only after member added, but also after member deleted and member role changed.

Updated by Yuki Kita 4 months ago

Updated the patch to reflect the current trunk.

Updated by Eric Davis 2 months ago

  • Status changed from New to Resolved
  • Assigned to set to Eric Davis
  • % Done changed from 0 to 100
  • Resolution set to Fixed

Fixed in r3784. I did it a little differently and had the RJS in the MembersController send hideOnLoad() to the page itself. Thank you for the contribution.

Updated by Eric Davis 2 months ago

  • Status changed from Resolved to Closed

Merged to 0.9-stable for release.

Also available in: Atom PDF