Patch #6008

Move admin_menu to Redmine::MenuManager

Added by Jean-Baptiste Barth over 7 years ago. Updated over 7 years ago.

Status:ClosedStart date:2010-07-31
Priority:NormalDue date:
Assignee:Eric Davis% Done:

100%

Category:Code cleanup/refactoring
Target version:1.0.1

Description

Admin menu should be moved to a standard Redmine::MenuManager so that it can be modified in a plugin the same way we do with other menu.

For the moment the only way to modify this menu really (not just add something, reorganize or remove items for instance) is to override the view. If 2 plugins do this, the 2nd will override 1st modifications. This problem doesn't occur anymore if the menu is managed with Redmine::MenuManager.

See patch attached. If it's functionnally OK, we can integrate this easily, it should not break anything in existing plugins.

move-admin-menu.diff Magnifier (3.42 KB) Jean-Baptiste Barth, 2010-07-31 11:10

Associated revisions

Revision 3909
Added by Eric Davis over 7 years ago

Use the MenuManager for the Administration menu. #6008

Contributed by Jean-Baptiste Barth.

History

#1 Updated by Eric Davis over 7 years ago

  • Status changed from New to Resolved
  • Assignee set to Eric Davis
  • % Done changed from 0 to 100

Good find, I forgot about this refactoring. Committed in r3909.

#2 Updated by Eric Davis over 7 years ago

  • Status changed from Resolved to Closed

Merged to 1.0-stable for release in 1.0.1.

Also available in: Atom PDF