Defect #6163

Bad CSS class for calendar project menu_item

Added by Jean-Baptiste Barth over 7 years ago. Updated over 7 years ago.

Status:ClosedStart date:2010-08-17
Priority:NormalDue date:
Assignee:Eric Davis% Done:

100%

Category:UI
Target version:1.0.1
Resolution:Fixed Affected version:

Description

See screenshot attached.

It's due to a CSS class name collision with calendar.css, which defines ".calendar". I wonder if it should be fixed in calendar.css or in classes definitions for our menu items.

calendar_item_bad_css.png (9.86 KB) Jean-Baptiste Barth, 2010-08-17 21:21

calendar_css_conflict.diff Magnifier (7.2 KB) Adam Soltys, 2010-08-18 17:03

Associated revisions

Revision 3950
Added by Eric Davis over 7 years ago

Scope the calendar popup CSS so it doesn't conflict with the Calendar menu. #6163

Contributed by Adam Soltys

History

#1 Updated by Eric Davis over 7 years ago

  • Assignee set to Eric Davis

What theme? I didn't see that when I tested.

#2 Updated by Jean-Baptiste Barth over 7 years ago

Default, but no matter the theme. You get this when calendar.css is included, which happens whenever calendar popups are used on the page I think. "New issue" tab for instance.

#3 Updated by Adam Soltys over 7 years ago

I noticed this yesterday too and attempted a fix: http://github.com/asoltys/redmine/tree/calendar_css_conflict

#4 Updated by Jean-Baptiste Barth over 7 years ago

Looks ok to me, thanks. As Eric assigned it to himself, I let him check if he's ok and commit this patch.

#5 Updated by Eric Davis over 7 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
  • Resolution set to Fixed

Applied your patch Adam, thanks for the fix (r3950).

To make it easier on me, could you format your patches to the Commit standards. (It's new but it will help save me time when applying patches in git).

#6 Updated by Eric Davis over 7 years ago

  • Status changed from Resolved to Closed

Merged to 1.0-stable for release in 1.0.1.

Also available in: Atom PDF