Project

General

Profile

Feature #13718 ยป issue-13718.diff

Toshi MARUYAMA, 2015-12-21 05:44

View differences:

lib/redmine/views/builders/json.rb
super
callback = request.params[:callback] || request.params[:jsonp]
if callback && Setting.jsonp_enabled?
self.jsonp = callback.to_s.gsub(/[^a-zA-Z0-9_]/, '')
self.jsonp = callback.to_s.gsub(/[^a-zA-Z0-9_.]/, '')
end
end
test/integration/api_test/jsonp_test.rb
def test_jsonp_should_strip_invalid_characters_from_callback
with_settings :jsonp_enabled => '1' do
get '/trackers.json?callback=+-aA$1_'
get '/trackers.json?callback=+-aA$1_.'
end
assert_response :success
assert_match %r{^aA1_\(\{"trackers":.+\}\)$}, response.body
assert_match %r{^aA1_.\(\{"trackers":.+\}\)$}, response.body
assert_equal 'application/javascript; charset=utf-8', response.headers['Content-Type']
end
    (1-1/1)