Redmine

import { Controller } from "@hotwired/stimulus";

export default class extends Controller {

  static targets = ["source", "name", "redirectUri", "message"];

  static values = {

    invalidMessage: String,

    unknownScopesMessage: String

  };

  openFilePicker(event) {

    event.preventDefault();

    this.sourceTarget.click();

  }

  async apply() {

    const file = this.sourceTarget.files[0];

    if (!file) return;

    let metadata;

    try {

      metadata = JSON.parse(await file.text());

    } catch {

      metadata = null;

    }

    if (metadata === null || typeof metadata !== "object" || Array.isArray(metadata)) {

      this.showMessage(this.invalidMessageValue, true);

      return;

    }

    if (typeof metadata.client_name === "string") {

      this.nameTarget.value = metadata.client_name;

    }

    if (Array.isArray(metadata.redirect_uris)) {

      this.redirectUriTarget.value = metadata.redirect_uris.join("\n");

    }

    const unknownScopes = this.applyScopes(metadata.scope);

    if (unknownScopes.length > 0) {

      this.showMessage(`${this.unknownScopesMessageValue} ${unknownScopes.join(", ")}`, true);

    } else {

      this.clearMessage();

    }

  }

  applyScopes(scope) {

    if (typeof scope !== "string") return [];

    const requestedScopes = scope.split(/\s+/).filter((s) => s.length > 0);

    const knownScopes = new Set();

    const checkboxes = this.element.querySelectorAll('input[type="checkbox"][name="doorkeeper_application[scopes][]"]');

    checkboxes.forEach((checkbox) => {

      knownScopes.add(checkbox.value);

      // disabled checkboxes are public permissions that are always granted

      if (checkbox.disabled) return;

      checkbox.checked = requestedScopes.includes(checkbox.value);

    });

    return requestedScopes.filter((s) => !knownScopes.has(s));

  }

  showMessage(text, isError) {

    this.messageTarget.textContent = text;

    this.messageTarget.className = isError ? "flash error" : "flash notice";

  }

  clearMessage() {

    this.messageTarget.textContent = "";

    this.messageTarget.removeAttribute("class");

  }

}

  <p><%= f.text_field :name, :required => true, :data => {'oauth-metadata-import-target' => 'name'} %></p>

    <%= f.textarea :redirect_uri, :required => true, :size => 60, :label => :'activerecord.attributes.doorkeeper/application.redirect_uri',

          :data => {'oauth-metadata-import-target' => 'redirectUri'} %>

<div data-controller="oauth-metadata-import"

     data-oauth-metadata-import-invalid-message-value="<%= l(:error_can_not_read_import_file) %>"

     data-oauth-metadata-import-unknown-scopes-message-value="<%= l(:text_oauth_import_client_metadata_unknown_scopes) %>">

<div class="contextual">

  <%= link_to sprite_icon('import', l(:button_import)), '#',

        :class => 'icon icon-import',

        :data => {:action => 'oauth-metadata-import#openFilePicker'} %>

</div>

<%= file_field_tag 'oauth_metadata_file', :class => 'hidden',

      :accept => '.json,application/json',

      :data => {'oauth-metadata-import-target' => 'source', :action => 'oauth-metadata-import#apply'} %>

<p data-oauth-metadata-import-target="message"></p>

</div>

<div data-controller="oauth-metadata-import"

     data-oauth-metadata-import-invalid-message-value="<%= l(:error_can_not_read_import_file) %>"

     data-oauth-metadata-import-unknown-scopes-message-value="<%= l(:text_oauth_import_client_metadata_unknown_scopes) %>">

<div class="contextual">

  <%= link_to sprite_icon('import', l(:button_import)), '#',

        :class => 'icon icon-import',

        :data => {:action => 'oauth-metadata-import#openFilePicker'} %>

</div>

<%= file_field_tag 'oauth_metadata_file', :class => 'hidden',

      :accept => '.json,application/json',

      :data => {'oauth-metadata-import-target' => 'source', :action => 'oauth-metadata-import#apply'} %>

<p data-oauth-metadata-import-target="message"></p>

</div>

  text_oauth_import_client_metadata_unknown_scopes: 'The following scopes are not available here and were ignored:'

  text_oauth_import_client_metadata_unknown_scopes: '次のスコープはこのRedmineでは利用できないため無視されました:'

# frozen_string_literal: true

# Redmine - project management software

# Copyright (C) 2006-  Jean-Philippe Lang

#

# This program is free software; you can redistribute it and/or

# modify it under the terms of the GNU General Public License

# as published by the Free Software Foundation; either version 2

# of the License, or (at your option) any later version.

#

# This program is distributed in the hope that it will be useful,

# but WITHOUT ANY WARRANTY; without even the implied warranty of

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

# GNU General Public License for more details.

#

# You should have received a copy of the GNU General Public License

# along with this program; if not, write to the Free Software

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

require_relative '../application_system_test_case'

class Oauth2ApplicationsSystemTest < ApplicationSystemTestCase

  def test_new_application_form_can_be_filled_from_client_metadata_file

    log_user('admin', 'admin')

    with_settings :rest_api_enabled => '1' do

      visit '/oauth/applications/new'

      attach_metadata_file(

        'client_name' => 'Metadata App',

        'redirect_uris' => ['https://example.com/cb', 'https://example.net/cb'],

        'scope' => 'view_issues add_issues unknown_scope'

      )

      assert_equal 'Metadata App', find('#doorkeeper_application_name').value

      assert_equal "https://example.com/cb\nhttps://example.net/cb",

                   find('#doorkeeper_application_redirect_uri').value

      assert find('#doorkeeper_application_scopes_view_issues').checked?

      assert find('#doorkeeper_application_scopes_add_issues').checked?

      assert_not find('#doorkeeper_application_scopes_edit_issues').checked?

      # public permissions are always granted and must stay checked

      assert find('#doorkeeper_application_scopes_view_project').checked?

      assert_selector 'p.flash.error', :text => /unknown_scope/

    end

  end

  def test_importing_client_metadata_again_should_uncheck_scopes_not_listed

    log_user('admin', 'admin')

    with_settings :rest_api_enabled => '1' do

      visit '/oauth/applications/new'

      check 'View Issues'

      check 'Add issues'

      attach_metadata_file('scope' => 'add_issues')

      assert_not find('#doorkeeper_application_scopes_view_issues').checked?

      assert find('#doorkeeper_application_scopes_add_issues').checked?

      assert_no_selector 'p.flash.error'

    end

  end

  def test_invalid_client_metadata_file_should_show_an_error_and_keep_the_form_untouched

    log_user('admin', 'admin')

    with_settings :rest_api_enabled => '1' do

      visit '/oauth/applications/new'

      fill_in 'Name', :with => 'Untouched'

      attach_metadata_file('not json')

      assert_selector 'p.flash.error'

      assert_equal 'Untouched', find('#doorkeeper_application_name').value

    end

  end

  private

  def attach_metadata_file(metadata)

    @metadata_file = Tempfile.new(['client_metadata', '.json'])

    @metadata_file.write(metadata.is_a?(String) ? metadata : metadata.to_json)

    @metadata_file.close

    # the file input is visually hidden behind the Import button

    attach_file 'oauth_metadata_file', @metadata_file.path, :make_visible => true

  end

end