Project

General

Profile

Actions
Copy link

Patch #12313

closed

Misspelling in auth_sources_controller.rb

Added by Daniel Felix over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
0.08 h

Description

Replace in /app/controllers/auth_sources_controller.rb (line 28-31)
def new
klass_name = params[:type] || 'AuthSourceLdap'
@auth_source = AuthSource.new_subclass_instance(klass_name, params[:auth_source])
end

with:
def new
class_name = params[:type] || 'AuthSourceLdap'
@auth_source = AuthSource.new_subclass_instance(class_name, params[:auth_source])
end

klass_name => class_name

Sorry for the missing patch, but i haven't a sourcecode repository currently on this machine.

Actions
Copy link
 #1

Updated by Toshi MARUYAMA over 11 years ago

It is popular to use klass.
class is reserved name in many languages and frameworks.

Actions
Copy link
 #2

Updated by Daniel Felix over 11 years ago

  • Status changed from New to Closed

Hi Toshi,

thanks for this hint.

I just thought it was an error, cause the word "klasse" in german means class. So I thought, it could be added as "denglish" (Mix from german (deutsch) and english). ;-)

I often seen this in some german projects. :-)

Actions
Copy link

Also available in: Atom PDF