Patch #14138

Output changeset comment in html title

Added by Toshi MARUYAMA over 9 years ago. Updated over 9 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:2.4.0

Description

diff --git a/app/views/repositories/revision.html.erb b/app/views/repositories/revision.html.erb
--- a/app/views/repositories/revision.html.erb
+++ b/app/views/repositories/revision.html.erb
@@ -94,4 +94,8 @@
 <%= stylesheet_link_tag "scm" %>
 <% end %>

-<% html_title("#{l(:label_revision)} #{format_revision(@changeset)}") -%>
+<%
+  title = "#{l(:label_revision)} #{format_revision(@changeset)}" 
+  title << " #{truncate(@changeset.comments, :length => 80)}" 
+  html_title(title)
+ -%>

old.png (44.8 KB) Toshi MARUYAMA, 2013-05-24 10:14

patch.png (54.9 KB) Toshi MARUYAMA, 2013-05-24 10:14

Associated revisions

Revision 11908
Added by Toshi MARUYAMA over 9 years ago

add test of revision page title (#14138)

Revision 11909
Added by Toshi MARUYAMA over 9 years ago

add changeset comment in revision page title (#14138)

History

#1 Updated by Toshi MARUYAMA over 9 years ago

  • Subject changed from Output changeset title in html title to Output changeset commnet in html title

#2 Updated by Daniel Felix over 9 years ago

  • Subject changed from Output changeset commnet in html title to Output changeset comment in html title

#3 Updated by Daniel Felix over 9 years ago

Hi Toshi,

I applied your change. But I can't recognize any change. Can you give me a hint where to look for a change?

Best regards,
Daniel

#4 Updated by Toshi MARUYAMA over 9 years ago

These are images.

no patch

patch

#5 Updated by Daniel Felix over 9 years ago

Ah thanks! Haven't noticed it as I tested it in IE10 with tabs.

Seems to work, no problems. For my instance.

#6 Updated by Toshi MARUYAMA over 9 years ago

  • Status changed from New to Closed
  • Target version set to 2.4.0

Committed in trunk r11909.

Also available in: Atom PDF