Project

General

Profile

Actions

Patch #14138

closed

Output changeset comment in html title

Patch #14138: Output changeset comment in html title

Added by Toshi MARUYAMA over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:

Description

diff --git a/app/views/repositories/revision.html.erb b/app/views/repositories/revision.html.erb
--- a/app/views/repositories/revision.html.erb
+++ b/app/views/repositories/revision.html.erb
@@ -94,4 +94,8 @@
 <%= stylesheet_link_tag "scm" %>
 <% end %>

-<% html_title("#{l(:label_revision)} #{format_revision(@changeset)}") -%>
+<%
+  title = "#{l(:label_revision)} #{format_revision(@changeset)}" 
+  title << " #{truncate(@changeset.comments, :length => 80)}" 
+  html_title(title)
+ -%>

Files

old.png (44.8 KB) old.png Toshi MARUYAMA, 2013-05-24 10:14
patch.png (54.9 KB) patch.png Toshi MARUYAMA, 2013-05-24 10:14

Updated by Toshi MARUYAMA over 13 years ago Actions #1

  • Subject changed from Output changeset title in html title to Output changeset commnet in html title

Updated by Daniel Felix over 13 years ago Actions #2

  • Subject changed from Output changeset commnet in html title to Output changeset comment in html title

Updated by Daniel Felix over 13 years ago Actions #3

Hi Toshi,

I applied your change. But I can't recognize any change. Can you give me a hint where to look for a change?

Best regards,
Daniel

Updated by Toshi MARUYAMA over 13 years ago Actions #4

These are images.

no patch

patch

Updated by Daniel Felix over 13 years ago Actions #5

Ah thanks! Haven't noticed it as I tested it in IE10 with tabs.

Seems to work, no problems. For my instance.

Updated by Toshi MARUYAMA over 13 years ago Actions #6

  • Status changed from New to Closed
  • Target version set to 2.4.0

Committed in trunk r11909.

Actions

Also available in: PDF Atom