Defect #3807
text_journal_changed, text_journal_set_to, text_journal_deleted
Status: | Closed | Start date: | 2009-09-02 | |
---|---|---|---|---|
Priority: | Normal | Due date: | 2009-09-05 | |
Assignee: | % Done: | 0% | ||
Category: | Translations | |||
Target version: | 0.9.0 | |||
Resolution: | Fixed | Affected version: |
Description
issues_helper.rb
composes message strings for text_journal_changed
, text_journal_set_to
, and text_journal_deleted
messages by string concatenation, like this:
label + " " + l(:text_journal_changed, :old => old_value, :new => value)
This produces clumsy messages with russian translation.
The label should be moved to message arguments, and russian translations should be changed as follows:
text_journal_changed: "Параметр '{{label}}' изменен с {{old}} на {{new}}" text_journal_deleted: "Значение '{{label}}' удалено" text_journal_set_to: "Параметр '{{label}}' изменен на {{value}}"
Associated revisions
Changing l10n messages (fixes #3807)
History
#1
Updated by Azamat Hackimov almost 13 years ago
- File issues_helper.rb-fix.patch
added
- Status changed from New to 7
- Assignee changed from Azamat Hackimov to Jean-Philippe Lang
OK, I created patch to solve this, but final decision will take Jean-Philippe.
#2
Updated by Eric Davis almost 13 years ago
Azamat Hackimov:
Looks good to me. We would need to change any other translation also, otherwise Rails might throw an exception from missing I18n arguments.
#3
Updated by Azamat Hackimov almost 13 years ago
- Due date set to 2009-09-05
- Status changed from 7 to Closed
- Assignee changed from Jean-Philippe Lang to Azamat Hackimov
- Target version set to 0.9.0
- Resolution set to Fixed
OK, patch now in tree.