Defect #3807

text_journal_changed, text_journal_set_to, text_journal_deleted

Added by alexander smishlajev almost 13 years ago. Updated almost 13 years ago.

Status:ClosedStart date:2009-09-02
Priority:NormalDue date:2009-09-05
Assignee:Azamat Hackimov% Done:


Target version:0.9.0
Resolution:Fixed Affected version:


issues_helper.rb composes message strings for text_journal_changed, text_journal_set_to, and text_journal_deleted messages by string concatenation, like this:

label + " " + l(:text_journal_changed, :old => old_value, :new => value)

This produces clumsy messages with russian translation.

The label should be moved to message arguments, and russian translations should be changed as follows:

  text_journal_changed: "Параметр '{{label}}' изменен с {{old}} на {{new}}" 
  text_journal_deleted: "Значение '{{label}}' удалено" 
  text_journal_set_to: "Параметр '{{label}}' изменен на {{value}}" 

issues_helper.rb-fix.patch Magnifier - issues_helper.rb-fix.patch (3.15 KB) Azamat Hackimov, 2009-09-02 19:45

Associated revisions

Revision 2856
Added by Azamat Hackimov almost 13 years ago

Changing l10n messages (fixes #3807)


#1 Updated by Azamat Hackimov almost 13 years ago

OK, I created patch to solve this, but final decision will take Jean-Philippe.

#2 Updated by Eric Davis almost 13 years ago

Azamat Hackimov:

Looks good to me. We would need to change any other translation also, otherwise Rails might throw an exception from missing I18n arguments.

#3 Updated by Azamat Hackimov almost 13 years ago

  • Due date set to 2009-09-05
  • Status changed from 7 to Closed
  • Assignee changed from Jean-Philippe Lang to Azamat Hackimov
  • Target version set to 0.9.0
  • Resolution set to Fixed

OK, patch now in tree.

Also available in: Atom PDF