Patch #6416
When viewing utf-8 text file in repository, it is downloaded
| Status: | Closed | Start date: | 2010-09-16 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | SCM | |||
| Target version: | - |
Description
I want to view the utf-8 text file in repository, but it is downloaded.
In RepositoriesController#entry(), String#is_binary_data? is used to determine the file is binary or not.
But String#is_binary_data? return true even if the file is utf-8 text.
I wrote a patch to fix this problem.
repositories_controller.patch 
(1.13 KB)
Related issues
History
#1
Updated by Yar Isakov over 9 years ago
I want to confirm this bug. Some files in utf-8 encoding are downloading instead of showing.
#2
Updated by Toshi MARUYAMA over 9 years ago
- Category set to SCM
#3
Updated by Toshi MARUYAMA about 9 years ago
- Status changed from New to 7
- Assignee set to Toshi MARUYAMA
#4
Updated by Toshi MARUYAMA about 9 years ago
- Status changed from 7 to Closed
- Assignee deleted (
Toshi MARUYAMA)
I confirmed source:trunk/config/locales/ja.yml is as binary.
repositories_controller.patch is only for UTF-8.
Redmine supports multi encoding.
For example, ISO-8859-1, Japanese Shift_JIS, EUC-JP...
Iconv passes converting from ISO-8859-1 to UTF-8 with no error.
I will fix #6256 in another way.