Defect #7794
Internal server error on formatting an issue as a PDF in Japanese
| Status: | Closed | Start date: | 2011-03-06 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Toshi MARUYAMA | % Done: | 0% | |
| Category: | PDF export | |||
| Target version: | 1.1.3 | |||
| Resolution: | Fixed | Affected version: | 1.1.2 |
Description
- params[:format] is pdf
- AcceptLanguage: ja
- @issue.description contains an ASCII control character.
This is because the map SJIS_widths does not have a mapping for control characters and it leads concatenation of a String and nil at vendor/plugins/rfpdf/lib/rfpdf/japanese.rb:182.
The attached patch fixes this problem.
ja-pdf.patch 
(1.67 KB)
test-1-org.pdf (5.48 KB)
test-1-ja-pdf.patch.pdf (5.98 KB)
test-1-ja-pdf_fix.patch.pdf (5.48 KB)
ja-pdf_fix.patch
(627 Bytes)
Related issues
Associated revisions
Fix an internal server error on formatting an issue as a PDF in Japanese (#7794).
Contributed by Yuki Sonoda.
History
#1
Updated by Toshi MARUYAMA about 9 years ago
- Status changed from New to 7
- Assignee set to Toshi MARUYAMA
#2
Updated by Toshi MARUYAMA about 9 years ago
- Tracker changed from Patch to Defect
- Subject changed from Fix for an internal server error on formatting an issue as a PDF in Japanese to Internal server error on formatting an issue as a PDF in Japanese
#3
Updated by Toshi MARUYAMA about 9 years ago
- Target version set to 1.1.3
- Affected version (unused) set to 1.1.2
- Affected version set to 1.1.2
I confirmed Japanese locale has problem.
Korean, Simplified and Traditional Chinese don't have problem.
#4
Updated by Toshi MARUYAMA about 9 years ago
- Status changed from 7 to Closed
- Resolution set to Fixed
#5
Updated by Jun NAITOH about 9 years ago
- File test-1-org.pdf added
- File test-1-ja-pdf.patch.pdf added
- File test-1-ja-pdf_fix.patch.pdf added
- File ja-pdf_fix.patch added
- Status changed from Closed to Reopened
When I tested #61 in trunk, now. I found ja-pdf.patch problem.
I retested in Redmine 1.1.2 + ja-pdf.patch.
Test string is "A B C D E F G H I J K L M N O P Q R S T U V W X Y Z a b c d e f g h i j k l m n o p q r s t u v w x y z 1 2 3 4 5 6 7 8 9 0"
- Redmine 1.1.2 : test-1-org.pdf
- Redmine 1.1.2 + ja-pdf.patch : test-1-ja-pdf.patch.pdf
The width of the ASCII character has changed by ja-pdf.patch.
I rewrite ja-pdf_fix.patch for Redmine 1.1.2.
- Redmine 1.1.2 + ja-pdf_fix.patch : test-1-ja-pdf_fix.patch.pdf
#6
Updated by Toshi MARUYAMA about 9 years ago
- Status changed from Reopened to Closed
I have committed r5271 in 1.1-stable.
Thanks.
#7
Updated by Toshi MARUYAMA about 9 years ago
- Status changed from Closed to Reopened
#8
Updated by Toshi MARUYAMA about 9 years ago
- Status changed from Reopened to Closed