Project

General

Profile

Actions
Copy link

Defect #9466

closed

Watchers list appers very slow on issue page after upgrade from 1.0.1 to 1.2.1

Added by Sergey Besedin about 14 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Issues
Target version:
-
Start date:
2011-10-24
Due date:
% Done:

0%

Estimated time:
Resolution:
Wont fix
Affected version:
1.2.1

Description

I have ~90 users. In production mode when i press "add watcher", select-tag appears after 20 sec loading.

Problem with file: vendor/plugins/acts_as_watchable/lib/acts_as_watchable.rb:

def addable_watcher_users
  users = self.project.users.sort - self.watcher_users
  if respond_to?(:visible?)
    users.reject! {|user| !visible?(user)}
  end
  users
end

Recursive visibility check make mass sql-queries, so i just cut it off.

Here my logs before and after and patch.

Files

Download all files
watchers-no-visibility-check.log (2.52 KB) watchers-no-visibility-check.log Sergey Besedin, 2011-10-24 19:20
watchers-visibility-check.log (64.6 KB) watchers-visibility-check.log Sergey Besedin, 2011-10-24 19:20
watchers.patch (632 Bytes) watchers.patch Sergey Besedin, 2011-10-24 19:20
Actions
Copy link
 #1

Updated by Etienne Massip about 14 years ago

  • Category set to Issues
Actions
Copy link
 #2

Updated by Go MAEDA about 1 month ago

  • Status changed from New to Closed
  • Resolution set to Wont fix

In r12673 (Redmine 2.5.0), the call to the addable_watcher_users method was removed. Therefore, the performance issue with this method reported in this issue should no longer occur in the current code.

Actions
Copy link

Also available in: Atom PDF