Defect #9832
Revision graph height should depend on height of rows in revisions table
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | SCM | |||
| Target version: | 1.3.1 | |||
| Resolution: | Fixed | Affected version: | 1.3.0 |
Description
The new revision graph from #5501 is nice and looks fine - at least on the default theme. However, it doesn't behave well when displayed using many of the existing third party themes.
At the very least the graph should adapt to the actual height of the rows of the revisions list instead of blindly assuming a hardcoded value of 20 pixels.
The attached patch fixes this.
get_height_from_rows.diff 
(562 Bytes)
1.3-stable-r8781.png (15.4 KB)
1.3-stable-r8796.png (17.7 KB)
theme-simple.diff
(601 Bytes)
Related issues
Associated revisions
scm: fix revision graph height is hard-coded (#9832)
Contributed by Jakob Skjerning.
History
#1
Updated by Jakob Skjerning over 9 years ago
Redmine version: Redmine 1.3.0.devel.8277 (MySQL)
Output from script/about:
About your application's environment
Ruby version 1.8.7 (i686-darwin10.8.0)
RubyGems version 1.3.7
Rack version 1.1.2
Rails version 2.3.14
Active Record version 2.3.14
Active Resource version 2.3.14
Action Mailer version 2.3.14
Active Support version 2.3.14
Application root /Users/jakob/Projects/OpenSource/redmine/redmine-trunk
Environment development
Database adapter mysql
Database schema version 20111201201315
#2
Updated by Toshi MARUYAMA over 9 years ago
- Category changed from UI to SCM
#3
Updated by Toshi MARUYAMA about 9 years ago
- Affected version (unused) changed from devel to 1.3.0
- Affected version set to 1.3.0
#4
Updated by Toshi MARUYAMA about 9 years ago
- Target version set to 1.3.1
#5
Updated by Toshi MARUYAMA about 9 years ago
- File 1.3-stable-r8781.png added
- File 1.3-stable-r8796.png added
- File theme-simple.diff added
- Status changed from New to Closed
- Resolution set to Fixed
These are images with attachment theme.
