Defect #11290
ParseDate missing in Ruby 1.9x
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | Jean-Philippe Lang | % Done: | 0% | |
| Category: | Ruby support | |||
| Target version: | 2.1.1 | |||
| Affected version: | Resolution: | Fixed |
Description
I'm running Redmine on a Ruby 1.9x interpreter. This version has no ParseDate that is used in http://www.redmine.org/projects/redmine/repository/changes/trunk/lib/SVG/Graph/TimeSeries.rb
Because you use it 2 times with the pattern
arr = ParseDate.parsedate( data[:data][i] )
t = Time.local( *arr[0,6].compact )
you can simply replace it with
t = DateTime.parse( data[:data][i] ).to_time
Related issues
History
#1 Updated by Gabriel Mazetto 8 months ago
This issue affects RedmineGraphsPlugin (which can be found at: https://github.com/hdgarrood/redmine-graphs-plugin/network
Here is a patch for 2.1.0:
diff --git a/lib/SVG/Graph/TimeSeries.rb b/lib/SVG/Graph/TimeSeries.rb
index ee47359..bfa7c96 100644
--- a/lib/SVG/Graph/TimeSeries.rb
+++ b/lib/SVG/Graph/TimeSeries.rb
@@ -1,5 +1,4 @@
require 'SVG/Graph/Plot'
-require 'parsedate'
module SVG
module Graph
@@ -157,8 +156,7 @@ module SVG
y = []
data[:data].each_index {|i|
if i%2 == 0
- arr = ParseDate.parsedate( data[:data][i] )
- t = Time.local( *arr[0,6].compact )
+ t = DateTime.parse( data[:data][i] ).to_time
x << t.to_i
else
y << data[:data][i]
@@ -173,8 +171,7 @@ module SVG
protected
def min_x_value=(value)
- arr = ParseDate.parsedate( value )
- @min_x_value = Time.local( *arr[0,6].compact ).to_i
+ @min_x_value = DateTime.parse( data[:data][i] ).to_time
end
#2 Updated by Jean-Philippe Lang 8 months ago
- Category set to Ruby support
- Status changed from New to Resolved
- Assignee set to Jean-Philippe Lang
- Target version set to 2.1.1
- Resolution set to Fixed
Patch committed in r10439.
#3 Updated by Jean-Philippe Lang 8 months ago
- Status changed from Resolved to Closed
Merged in 2.1-stable.
#4 Updated by Hein Gustavsen 5 months ago
This patch is incorrect. Value is not used in the min_x_value method. It should look like this:
def min_x_value=(value) @min_x_value = DateTime.parse( value ).to_time end
#5 Updated by Toshi MARUYAMA 5 months ago
Hein Gustavsen wrote:
This patch is incorrect. Value is not used in the min_x_value method. It should look like this:
[...]
I have created new issue #12711, thanks.