Impersonate user through REST API auth
|Assignee:||Jean-Philippe Lang||% Done:|
The following patch implement a 'switch user' feature which lets an admin-level user impersonate any other user in the context of the REST API.
For any API authentication method, it is allowed to either pass a 'su' parameter or a 'X-Redmine-Switch-User' header, which is only considered if the primary auth led to an admin-level user. The expected value is a user 'login' (no ID or API key).
This is currently very useful when linking different applications with Redmine which share the same authentication reference (LDAP in my case), but don't have access to user's credentials (their Redmine API keys or their plain password). I use an admin-level account for every app which wants to talk with Redmine, but this app should ideally lower its privileges to its current user. This feature does just that, without diving into complex SSO problems.
#4 Updated by Vincent Caron almost 7 years ago
- File api-auth-switch-user-v2.patch added
Is the parameter option really needed?
I don't think so, I simply mimicked the api_key implementation which proposed both a param and a header for authentication. I personnaly only use the header way.
I think we should handle the case of an invalid username with a specific error response (eg. 412 Precondition Failed seems appropriate).
Indeed. Right now it will continue as 'admin' which is unsafe.
Find attached a new patch which takes into account those two remarks.
#5 Updated by Jean-Philippe Lang almost 7 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Feature added in r10608, thanks.
Patch was slightly refactored and tests were added. A small change was introduced: a 412 response will be returned if the given username exists but is not active (eg. locked).