Defect #12824

Useless "edit" link in workflow menu

Added by Daniel Felix almost 5 years ago. Updated over 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:2.4.0
Resolution:Fixed Affected version:2.2.1

Description

Hi,

there is a useless link in the topmenu of the workflow section. I can click on "edit" even if I need to choose the "edit" button after some role and tracker selection. This edit button just leads me back on the same page.

Best regards,
Daniel


Related issues

Related to Redmine - Defect #2414: 'Add News Button' in 'Add news' Reopened

Associated revisions

Revision 12004
Added by Jean-Philippe Lang over 4 years ago

Useless "edit" link in workflow menu (#12824).

History

#1 Updated by Daniel Felix almost 5 years ago

  • Target version set to 2.2.3

#2 Updated by Jean-Philippe Lang almost 5 years ago

  • Target version changed from 2.2.3 to Candidate for next minor release

#3 Updated by Daniel Felix over 4 years ago

  • Target version changed from Candidate for next minor release to 2.3.1

Maybe this time this would find its way in the next minor release.

#4 Updated by Jean-Philippe Lang over 4 years ago

Should we only show Copy and Summary links when editing, only Edit and Summary links when copying and Edit and Copy links on the summary? I've tried and don't really like the way the menu changes when clicking its items.

#5 Updated by Daniel Felix over 4 years ago

What about deactivating those menu items. Something like grey them out? This would let the menu look the same on each link, but prevent the user from clicking edit if he is already in the edit mode.

Some idea how to use this could be the pointer-events setting in CSS.
See: http://css-tricks.com/pointer-events-current-nav/

There is just one regression: http://caniuse.com/#search=pointer-events
The IE support is not given.

Another idea would be to add this to the active menu item: onclick="return false"
Or just a jQuery function:

$(".currentMenu").click(function(){
return false;
});

Which suggests, that the current menu item get another class.

Maybe this idea is helpful.

#6 Updated by Jean-Philippe Lang over 4 years ago

  • Category changed from Issues workflow to UI
  • Target version changed from 2.3.1 to 2.4.0

#7 Updated by Jean-Philippe Lang over 4 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fixed in r12004 using another approach (similar to what was already done for trackers).

Also available in: Atom PDF