Patch #12911

Fix 500 error for requests to the settings path for non-configurable plugins

Added by Harry Garrood almost 5 years ago. Updated almost 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Code cleanup/refactoring
Target version:2.3.0

Description

When a non-configurable plugin is specified in a GET or POST to /settings/plugin/:id, a NoMethodError will be raised, and Redmine will respond with status 500.

The attached patch fixes this by rendering a 404 for both GETs and POSTs unless the plugin is configurable. It's based on trunk r11204.

I've also updated and added tests.

make_plugin_settings_path_404_for_non_configurable_plugins.patch Magnifier (1.63 KB) Harry Garrood, 2013-01-20 03:46

Associated revisions

Revision 11216
Added by Jean-Philippe Lang almost 5 years ago

Fix 500 error for requests to the settings path for non-configurable plugins (#12911).

Path by Harry Garrood.

History

#1 Updated by Jean-Philippe Lang almost 5 years ago

  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Target version set to 2.3.0

Patch committed in r11216, thanks!

Also available in: Atom PDF