Actions
Defect #12979
closedWiki link syntax commit:repo_a:abcd doesn't work
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
The wiki syntax commit:repo_a used to link hash-named changesets doesn't work if repo identifier has underscore symbol.
Maybe in this code https://github.com/redmine/redmine/blob/master/app/helpers/application_helper.rb#L751 used wrong regular expression.
when 'commit', 'source', 'export'
if project
repository = nil
if name =~ %r{^(([a-z0-9\-]+)\|)(.+)$}
repo_prefix, repo_identifier, name = $1, $2, $3
repository = project.repositories.detect {|repo| repo.identifier == repo_identifier}
else
repository = project.repository
end
Files
Related issues
Updated by Etienne Massip almost 12 years ago
- Tracker changed from Patch to Defect
- Status changed from New to Confirmed
- Target version set to Candidate for next minor release
Confirmed because I've observed the same behavior on my instance a week or two ago, but didn't dig into it.
Updated by Jean-Philippe Lang almost 12 years ago
- Category changed from Wiki to Text formatting
- Status changed from Confirmed to Resolved
- Assignee set to Jean-Philippe Lang
- Target version changed from Candidate for next minor release to 2.2.3
- Resolution set to Fixed
Fixed in r11281, the proposed path was not working.
Thanks for pointing this out.
Updated by Jean-Philippe Lang over 11 years ago
- Status changed from Resolved to Closed
Actions