Project

General

Profile

Actions
Copy link

Patch #15420

closed

Don't create duplicate wikis in tests

Added by George Gensure over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Code cleanup/refactoring
Target version:
2.5.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

test/fixtures/wikis.yml includes the unnecessary wiki wikis_002. test/unit/wiki_test.rb's test_create attempts to create an identical wiki, likely being the cause of this entry's inclusion. Its invalidity is that it creates a second wiki entry for project id 2, a violation of the has_one relationship between them. This was noticed with the addition of significant UNIQUE indices across a PostgreSQL instance of redmine and unit tests, where the mentioned test fails with the fixture in place.

Recommended patch is attached.

Files

Download all files
wikis.patch (322 Bytes) wikis.patch George Gensure, 2013-11-20 23:03
wikis.patch (1.07 KB) wikis.patch George Gensure, 2013-11-21 17:33
Actions
Copy link

Also available in: Atom PDF