Project

General

Profile

Actions

Defect #1826

closed

back_url entry becomes urlencoded

Added by Robert Chady over 15 years ago. Updated over 15 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
2008-08-28
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

I just updated my test install to the latest SVN version and noticed that back_url containd %2fredmine%2f instead of /redmine/. I had also done some apache configuration changes so I'm not sure if this was due to the Redmine update or my changes. Anyhow, I did verify that if back_url gets urlencoded, the call to redirect_to is going to result in getting directed to an invalid URL.

I'm not sure of the 'right' way to handle this -- I believe you need to either make sure it does not become urlencoded in the first place, or at least make sure the redirect_to call urldecodes it first.

On my test install I did a quick hack to add in a CGI::unescape() call inside the redirect_to call and it does work, but I'm not sure if that is the "best" way or not. I'll leave that decision to the people in charge. :)

Actions

Also available in: Atom PDF