Feature #19885

Raise time entries comments limit to 1024

Added by Future Link Corporation pkgsrc team almost 3 years ago. Updated over 2 years ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Time tracking
Target version:3.2.0
Resolution:Fixed

Description

See: source:/trunk/app/models/time_entry.rb#L42

The comments field in the time_entries table is defined as having a length of 1024 characters:

Yet, user comments are truncated at 255:

Let's not do that. :)

Note: This patch (partly) makes the comment field mandatory. That might not be what you want. It would be nice to have a way to require this field without patching the application though. :)


Related issues

Copied to Redmine - Feature #19886: Raise wiki edits comments limit to 1024 Closed

Associated revisions

Revision 14621
Added by Jean-Philippe Lang over 2 years ago

Raises time entries comments limit to 1024 (#19885).

History

#1 Updated by Future Link Corporation pkgsrc team almost 3 years ago

  • Copied to Feature #19886: Raise wiki edits comments limit to 1024 added

#2 Updated by Future Link Corporation pkgsrc team almost 3 years ago

Here is a patch for source:/trunk/app/views/timelog/_form.html.erb as well:

Again, noting that we're making the field mandatory, which might not be what you want (POLA).

#3 Updated by Toshi MARUYAMA almost 3 years ago

  • Status changed from New to Needs feedback

"comments" of "time_entries" is defined as 255.
source:tags/3.0.3/db/migrate/032_create_time_entries.rb#L8

I think you changed manually.

#4 Updated by Future Link Corporation pkgsrc team almost 3 years ago

Yes, you are correct. We did. Can that field be made longer by default? The length of 255 characters is rather short and doesn't allow for detailed time entries.

#5 Updated by Toshi MARUYAMA almost 3 years ago

See r4402.

#6 Updated by Future Link Corporation pkgsrc team almost 3 years ago

The diff you referenced doesn't apply to the time entries comment field.

#8 Updated by Future Link Corporation pkgsrc team almost 3 years ago

Yes, I understand that and we've done it. The point is that the stock password length between what the view allows and what the DB allows, by default, don't match. Thus, these comments get limited unnecessarily. Same deal for #19886. Please, apply these patches in this issue and #19886.

#9 Updated by Toshi MARUYAMA almost 3 years ago

  • Tracker changed from Patch to Feature
  • Status changed from Needs feedback to New

Because there is no completed patch, I change tracker.

#10 Updated by Toshi MARUYAMA almost 3 years ago

  • Target version set to 3.2.0

#11 Updated by Jean-Philippe Lang over 2 years ago

  • Subject changed from Comment field length for time entries is unnecessarily short to Raise time entries comments limit to 1024
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Limit raised to 1024 in r14621.

Also available in: Atom PDF