Feature #19886

Raise wiki edits comments limit to 1024

Added by Future Link Corporation pkgsrc team over 2 years ago. Updated over 2 years ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Wiki
Target version:3.2.0
Resolution:Fixed

Description

See: source:/trunk/app/models/wiki_content.rb#L25

The comments field in the wiki_content_versions table is defined as having a length of 1024 characters:

Yet, user comments are truncated at 255:

Let's not do that. :)

Note: This patch (partly) makes the comment field mandatory. That might not be what you want. It would be nice to have a way to require this field without patching the application though. :)


Related issues

Copied from Redmine - Feature #19885: Raise time entries comments limit to 1024 Closed

Associated revisions

Revision 14622
Added by Jean-Philippe Lang over 2 years ago

Raises wiki edits comments limit to 1024 (#19886).

History

#1 Updated by Future Link Corporation pkgsrc team over 2 years ago

  • Copied from Feature #19885: Raise time entries comments limit to 1024 added

#2 Updated by Toshi MARUYAMA over 2 years ago

  • Status changed from New to Needs feedback

"comments" of "wiki_content_versions" is defined as 255.
source:tags/3.0.3/db/migrate/029_create_wiki_contents.rb#L19

I think you changed manually.

#3 Updated by Future Link Corporation pkgsrc team over 2 years ago

Yes, you are correct. We did. Can that field be made longer by default? The length of 255 characters is rather short and doesn't allow for detailed time entries.

#4 Updated by Toshi MARUYAMA over 2 years ago

See r4402.

#5 Updated by Future Link Corporation pkgsrc team over 2 years ago

The diff you referenced doesn't apply to the wiki content versions comment field.

#7 Updated by Toshi MARUYAMA over 2 years ago

  • Tracker changed from Patch to Feature
  • Status changed from Needs feedback to New

Because there is no completed patch, I change tracker.

#8 Updated by Toshi MARUYAMA over 2 years ago

  • Target version set to 3.2.0

#9 Updated by Jean-Philippe Lang over 2 years ago

  • Subject changed from Comment field length for wiki edits is unnecessarily short to Raise wiki edits comments limit to 1024
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Limit raised to 1024 in r14622.

Also available in: Atom PDF