Project

General

Profile

Actions

Feature #20366

closed

upgrade jquery-rails to 4.0

Added by Antonio Terceiro almost 9 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Gems support
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

Hi,

I maintain redmine on debian, and there we are moving to jquery-rails 4.0. It would be really nice if redmine could also update to jquery-rails 4.0. Looking at the changelog, there is not a significant difference between 3.1 and 4.0, so this move shouldn't be a problem.

I am attaching a trivial patch that does this.


Files

0001-Update-jquery-rails-to-4.0.patch (631 Bytes) 0001-Update-jquery-rails-to-4.0.patch Antonio Terceiro, 2015-07-18 03:53
Actions #1

Updated by Toshi MARUYAMA almost 9 years ago

  • Tracker changed from Patch to Feature
  • Subject changed from please upgrade jquery-rails to 4.0 to upgrade jquery-rails to 4.0
Actions #2

Updated by Antonio Terceiro almost 9 years ago

is there a reason why redmine is carrying its own embedded copy of jquery and jquery-ui instead of relying on the one that jquery-rails already provides?

Actions #3

Updated by Toshi MARUYAMA almost 9 years ago

AFAIK, Redmine disables asset pipeline (#13927#note-2).

Actions #4

Updated by Go MAEDA almost 7 years ago

  • Category set to Gems support
  • Status changed from New to Resolved
  • Target version set to 4.0.0
  • Resolution set to Fixed

Redmine 4.0.0 will use latest jquery-rails gem.

source:sandbox/rails-5.1/Gemfile#L8

Actions #5

Updated by Jean-Philippe Lang almost 7 years ago

  • Status changed from Resolved to Closed
  • Target version deleted (4.0.0)
  • Resolution deleted (Fixed)

jquery-rails won't be no longer used in Redmine 4 as Rails does not rely on jquery for its UJS any more.
The gem dependency is removed in r16850.

Actions #6

Updated by Jean-Philippe Lang almost 7 years ago

As Redmine 3.4 bundles jquery-ujs, we could simply remove the gem dependency in 3.4. Would it help?

Actions

Also available in: Atom PDF