Patch #20508

Required file lib/redmine/hook.rb is patching autoloaded ApplicationHelper

Added by Ondřej Ezr almost 3 years ago. Updated almost 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Code cleanup/refactoring
Target version:3.2.0

Description

Redmine::Hook::Helper is in file, which is required, but is patching ApplicationHelper and that is loaded by Rails autoloading. So its patch is forgotten after reloading

hook_availability_after_reload.patch Magnifier (571 Bytes) Ondřej Ezr, 2015-08-11 02:00

Associated revisions

Revision 14510
Added by Jean-Philippe Lang almost 3 years ago

Required file lib/redmine/hook.rb is patching autoloaded ApplicationHelper (#20508).

Patch by Ondřej.

Revision 14520
Added by Jean-Philippe Lang almost 3 years ago

Reverts r14510 (#20508) and r14511 (#20507), tests broken.

Revision 14693
Added by Jean-Philippe Lang almost 3 years ago

Include helper instead of patching (#20508).

Revision 14694
Added by Jean-Philippe Lang almost 3 years ago

Extract classes to their own files to prevent loading issues (#20508).

History

#1 Updated by Jean-Philippe Lang almost 3 years ago

  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 3.2.0

Patch committed in r14510, thanks.

#2 Updated by Jean-Philippe Lang almost 3 years ago

  • Status changed from Closed to Reopened

#3 Updated by Jean-Philippe Lang almost 3 years ago

  • Status changed from Reopened to Closed

Different fix applied in r14693.

Also available in: Atom PDF