Patch #20661

Show visible spent time link for users allowed to view time entries.

Added by Martin Dubé about 2 years ago. Updated 9 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Time tracking
Target version:3.2.6

Description

With this little change, the spent time is back, but showing only hours visible by the user according to the new "time log visibility" permission.

show.html.erb.patch Magnifier (631 Bytes) Martin Dubé, 2015-09-02 15:25

spent-time-issues-index.png (10.8 KB) Go MAEDA, 2017-01-19 13:30

spent-time-issues-show.png (17.8 KB) Go MAEDA, 2017-01-19 13:35

20661-show-visible-spent-time.diff Magnifier (1.23 KB) Go MAEDA, 2017-01-19 13:57


Related issues

Related to Redmine - Patch #25526: Revert API change in spent_hours field in issue#show Closed

Associated revisions

Revision 16292
Added by Jean-Philippe Lang 9 months ago

Show visible spent time link for users allowed to view time entries (#20661).

Patch by Go MAEDA.

History

#1 Updated by Toshi MARUYAMA about 2 years ago

  • Status changed from New to Needs feedback

There are many "show.html.erb". Which show.html.erb?

#2 Updated by Martin Dubé about 2 years ago

app/views/issues/show.html.erb

Thanks

#3 Updated by Toshi MARUYAMA about 2 years ago

  • Status changed from Needs feedback to New

#4 Updated by Robert Korulczyk 9 months ago

+1

Works great on 3.3.1. Thanks.

#5 Updated by Go MAEDA 9 months ago

  • Category changed from UI to Time tracking

By this patch, different spent hours value is displayed for each user.
I am worried that it may cause confusion.

#6 Updated by Robert Korulczyk 9 months ago

Go MAEDA wrote:

By this patch, different spent hours value is displayed for each user.
I am worried that it may cause confusion.

It already work in this way in multiple places (issues list for example) - user can see only his own time log.

Personally I think that much more confusing is situation, where issues list contain more details about issue than issue detail view, and user can't easily see how many hours his spend on the issue.

#7 Updated by Go MAEDA 9 months ago

Robert Korulczyk wrote:

Go MAEDA wrote:

By this patch, different spent hours value is displayed for each user.
I am worried that it may cause confusion.

It already work in this way in multiple places (issues list for example) - user can see only his own time log.

Thank you for letting me know it. I didn't know. I agree with you now. I think that it is inconsistent.

#8 Updated by Go MAEDA 9 months ago

Updated the patch.
Also Issue.load_visible_total_spent_hours should be called to show correct value of total_spent_hours.

#10 Updated by Go MAEDA 9 months ago

  • Target version set to Candidate for next minor release

#11 Updated by Go MAEDA 9 months ago

  • Target version changed from Candidate for next minor release to 3.3.3

Let's resolve the inconsistency.
Setting target version to 3.3.3.

#12 Updated by Jean-Philippe Lang 9 months ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang

Committed, thanks.

#13 Updated by Jean-Philippe Lang 9 months ago

  • Status changed from Resolved to Closed

#14 Updated by Jean-Philippe Lang 9 months ago

  • Target version changed from 3.3.3 to 3.2.6

#15 Updated by Jean-Philippe Lang 7 months ago

  • Related to Patch #25526: Revert API change in spent_hours field in issue#show added

Also available in: Atom PDF