Defect #21263

Wiki lists in the sidebar are broken

Added by Ezequiel Hernandez about 2 years ago. Updated almost 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:3.2.1
Resolution:Fixed Affected version:

Description

The list in the Sidebar didn't work anymore since 2.5.X version. The same problem appear with

{{child_pages}}
macro.

I tested on demo.redmine.org with the same result.

But if you put an orderer list (with #) it works.

This is due to changes in the Redmine CSS in 2.4.0 that added lines 80 and 81 in the main Redmine CSS, see also #13242.

This is my redmine:

Redmine 2.6
Ruby 2.2

sidebar-ul-minimal-fix.patch Magnifier (1.29 KB) Daniel Ritz, 2015-11-19 16:03


Related issues

Related to Redmine - Feature #13242: Use <li> tags for lists Closed

Associated revisions

Revision 15134
Added by Jean-Philippe Lang almost 2 years ago

Wiki lists in the sidebar are broken (#21263).

Patch by Daniel Ritz.

Revision 15571
Added by Jean-Philippe Lang over 1 year ago

Render sidebar wiki h3 as regular sidebar h3 (#21263).

History

#1 Updated by Daniel Ritz about 2 years ago

Minimal fix for the problem attached:
  • Wrap the wiki text a div.wiki (which is required anyway for proper wiki text styling)
  • Undo the styles of form #sidebar xyz for #sidebar div.wiki xyz which works but is a bit ugly

The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class, say "content" and then match everything with #sidebar .content xyz. This would leave the .wiki stuff unaffected and would not require dirty "counter"-rules in application.css like I did in the minimal fix here.

#2 Updated by Toshi MARUYAMA about 2 years ago

#3 Updated by Toshi MARUYAMA about 2 years ago

  • Category set to UI
  • Target version set to 3.3.0

#4 Updated by Daniel Ritz almost 2 years ago

Daniel Ritz wrote:

The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class, say "content" and then match everything with #sidebar .content xyz. This would leave the .wiki stuff unaffected and would not require dirty "counter"-rules in application.css like I did in the minimal fix here.

Should I implement that or is the minimal fix enough?

#5 Updated by Jean-Philippe Lang almost 2 years ago

Daniel Ritz wrote:

The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class

Would you do that by adding a div in each view where there is some content for the sidebar?
If so, I'd prefer the patch you've already submitted.

#6 Updated by Daniel Ritz almost 2 years ago

Jean-Philippe Lang wrote:

Daniel Ritz wrote:

The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class

Would you do that by adding a div in each view where there is some content for the sidebar?
If so, I'd prefer the patch you've already submitted.

Yeah, pretty much. Thinking about it some more, the minimal fix is better as it allows sidebar content at any level to insert .wiki and formatted text that just works.

#7 Updated by Jean-Philippe Lang almost 2 years ago

  • Subject changed from List in Sidebar to Wiki lists in the sidebar are broken
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version changed from 3.3.0 to 3.2.1
  • Resolution set to Fixed

Patch committed, thanks for the feedback.

#8 Updated by Jean-Philippe Lang almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF