Project

General

Profile

Actions

Defect #22123

closed

Totals cannot be removed completely if some columns are set in the global settings

Added by Olivier Houdas about 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
High
Category:
Issues filter
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

1. Set Estimated time as a totalable column in Administration\Settings\Issue tracking
2. Display a list of issues: the estimated time is shown at the top and for each group if the list is grouped.
3. Unroll the Options, uncheck Estimated time (and any other column for totals if there are), Apply
Result: the Estimated time total is still shown.

In fact, it is not possible to completely remove totals if one or more column is set in the global settings.

For us, it is an issue,
1. Because we want to have default totalable columns, as this is not saved in Custom queries (for the moment, maybe it will come in the future?)
2. We want to produce some issue lists in PDF without showing time information, so without having totals shown.

A possible fix would be to add a hidden field in the issue filter form, and set it to indicate global settings should not apply when the user manually changed all totals to unchecked (attached patch, based on 3.2.0 code). This is not very elegant, but it works.


Files

Totalable_columns.patch (2.43 KB) Totalable_columns.patch Changes to allow deselecting all totals when default totalable columns are set in the Redmine Global settings Olivier Houdas, 2016-03-01 15:32
Totalable_columns-with_test.patch (3.9 KB) Totalable_columns-with_test.patch Patch updated with tests Olivier Houdas, 2016-04-28 16:14
Actions #1

Updated by Toshi MARUYAMA almost 8 years ago

Actions #2

Updated by Olivier Houdas almost 8 years ago

Sorry for the delay.
Here is a patch including tests. If you have a better solution than using sleep(1) for waiting for the page to reload after submitting the changes in totalable columns selection, I would be glad you update the test with it.

Actions #3

Updated by Toshi MARUYAMA almost 8 years ago

  • Target version set to 3.3.0
Actions #4

Updated by Jean-Philippe Lang almost 8 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang

I committed a slightly simpler fix in r15510. The test was changed to avoid the sleep(1).
Thanks for pointing this out.

Actions #5

Updated by Jean-Philippe Lang almost 8 years ago

  • Status changed from Resolved to Closed
  • Target version changed from 3.3.0 to 3.2.4
  • Resolution set to Fixed
Actions #6

Updated by Olivier Houdas almost 8 years ago

>>I committed a slightly simpler fix

Smart one... thank you.

Actions

Also available in: Atom PDF