Defect #22123

Totals cannot be removed completely if some columns are set in the global settings

Added by Olivier Houdas 11 months ago. Updated 7 months ago.

Status:ClosedStart date:
Priority:HighDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Issues filter
Target version:3.2.4
Resolution:Fixed Affected version:3.2.0

Description

1. Set Estimated time as a totalable column in Administration\Settings\Issue tracking
2. Display a list of issues: the estimated time is shown at the top and for each group if the list is grouped.
3. Unroll the Options, uncheck Estimated time (and any other column for totals if there are), Apply
Result: the Estimated time total is still shown.

In fact, it is not possible to completely remove totals if one or more column is set in the global settings.

For us, it is an issue,
1. Because we want to have default totalable columns, as this is not saved in Custom queries (for the moment, maybe it will come in the future?)
2. We want to produce some issue lists in PDF without showing time information, so without having totals shown.

A possible fix would be to add a hidden field in the issue filter form, and set it to indicate global settings should not apply when the user manually changed all totals to unchecked (attached patch, based on 3.2.0 code). This is not very elegant, but it works.

Totalable_columns.patch Magnifier - Changes to allow deselecting all totals when default totalable columns are set in the Redmine Global settings (2.43 KB) Olivier Houdas, 2016-03-01 15:32

Totalable_columns-with_test.patch Magnifier - Patch updated with tests (3.9 KB) Olivier Houdas, 2016-04-28 16:14

Associated revisions

Revision 15510
Added by Jean-Philippe Lang 7 months ago

Totals cannot be removed completely if some columns are set in the global settings (#22123).

History

#2 Updated by Olivier Houdas 9 months ago

Sorry for the delay.
Here is a patch including tests. If you have a better solution than using sleep(1) for waiting for the page to reload after submitting the changes in totalable columns selection, I would be glad you update the test with it.

#3 Updated by Toshi MARUYAMA 8 months ago

  • Target version set to 3.3.0

#4 Updated by Jean-Philippe Lang 7 months ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang

I committed a slightly simpler fix in r15510. The test was changed to avoid the sleep(1).
Thanks for pointing this out.

#5 Updated by Jean-Philippe Lang 7 months ago

  • Status changed from Resolved to Closed
  • Target version changed from 3.3.0 to 3.2.4
  • Resolution set to Fixed

#6 Updated by Olivier Houdas 7 months ago

>>I committed a slightly simpler fix

Smart one... thank you.

Also available in: Atom PDF