Defect #2286

Pb with CVS Server when CVSROOT does not contain user name

Added by Jerome Vanthournout about 9 years ago. Updated about 9 years ago.

Status:ClosedStart date:2008-12-06
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:0.8
Resolution:Fixed Affected version:0.7.3

Description

Depending on the CVS configuration, it is not mandatory to include a username in the CVSROOT.
For example, a valid CVSROOT is :ext:cvsservername:/cvsdatabase/projects1
With this CVSROOT format, redmine does not import correctly the information from CVS but does not report any error.
When configuring the CVSROOT with a username, :ext:username@cvsservername:/cvsdatabase/projects1, everything goes well.

The problem comes from the file name lib/redmine/scm/adapters/cvs_adapter.rb.
In the regulare expression line 137 root_url.gsub(/^:.*[^:]+:\d*/, ''), the should be optional.

History

#1 Updated by Jerome Vanthournout about 9 years ago

I forget one char in the previous description.

The problem comes from the file name lib/redmine/scm/adapters/cvs_adapter.rb.
In the regular expression line 137 root_url.gsub(/^:.*[^:]+:\d*/, ''), the @ should be optional.

#2 Updated by Jean-Philippe Lang about 9 years ago

  • Status changed from New to Closed
  • Target version set to 0.8
  • Resolution set to Fixed

Fixed in r2096. Thanks for pointing this out.

Also available in: Atom PDF