Patch #236

Patch for remote cvs server and non-English cvs environment

Added by Choi Jong Yoon almost 11 years ago. Updated over 7 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:-

Description

Hello.
I made a patch for cvs_adapter.rb

1. patch for remote cvs server
We installed Redmine to a server and this is not a cvs repository server.
so the cvsroot value is like below
:pserver::/home/cvsroot
so we should slice string before '/' in the line 145 of cvs_adapter.rb

this is not obliged to a user for local cvs repository, but is useful for user like me. :-)

2. patch for non-English User
When I want to insert the revision data to MySQL database, I should encode the non-English commit message to UTF-8.
This may be the problem of my environment(Korean), so please check the code !!

Thank you for reading.

patch.txt Magnifier (1.24 KB) Choi Jong Yoon, 2008-02-03 11:01


Related issues

Related to Redmine - Defect #3196: Don't properly support encoding of repositories (git) Closed 2009-04-17
Related to Redmine - Defect #2890: CVS fetch changesets for latin1 charset Closed 2009-03-03

History

#1 Updated by Jean-Philippe Lang almost 11 years ago

Hi,

Concerning 1, I used a different approach (the patch doesn't
work for a local CVS on windows).
I've tested it with a remove CVS, it now works fine as well.

Concerning 2, Setting.repositories_encodings can contain more
than encoding (comma separated). In this case, the patch doesn't
work as only one should be given to iconv.
I'll try to fix it later.

Thanks for the feedback.

Regards

#2 Updated by Toshi MARUYAMA over 7 years ago

  • Category set to SCM

#3 Updated by Toshi MARUYAMA over 7 years ago

  • Status changed from New to Closed

I added feature #1735 until r4983.

Also available in: Atom PDF