Patch #25019

Localization for Ukrainian language - completed

Added by Anton Oslyak 4 months ago. Updated 2 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Translations
Target version:3.4.0

Description

We fully transferred the file of localization for ukrainian language.

uk.yml

Redmine version 3.3.2.stable.16321

Ask you to include this file to redmine release.

uk.yml Magnifier - We fully transferred ukrainian localization (75.8 KB) Anton Oslyak, 2017-02-06 19:37

Ukrainian_localization.zip - Full files (35.5 KB) Anton Oslyak, 2017-02-14 00:51

ukrainian_localization.diff Magnifier - svn diff (166 KB) Anton Oslyak, 2017-02-14 00:51

ukrainian_localization_without_uk_yml.diff Magnifier (75.4 KB) Anton Oslyak, 2017-02-14 13:13

ukrainian_localization_without_uk_yml.patch Magnifier (75.4 KB) Anton Oslyak, 2017-02-14 18:49

Associated revisions

Revision 16410
Added by Toshi MARUYAMA 2 months ago

Ukrainian translation updated by Anton Oslyak (#25019)

History

#1 Updated by Toshi MARUYAMA 4 months ago

  • Tracker changed from Defect to Patch
  • Category changed from I18n to Translations

#2 Updated by VVD VVD 4 months ago

uk?
Why not ua?…

#3 Updated by Go MAEDA 4 months ago

VVD VVD wrote:

uk?
Why not ua?…

I think 'uk' is right ISO 639-1 code for Ukrainian language.

https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes
https://www.loc.gov/standards/iso639-2/php/code_list.php

#4 Updated by Mischa The Evil 4 months ago

See this issue on rails-i18n which explains uk vs. ua pretty well and see the leading IANA Language Subtag Registry. As such, uk is fine and in line with Rails core.

@Anton Oslyak: can you provide a patch1 against current trunk for this? That would make the life of the committer much prettier.. And can you also translate:

Ref.: HowTo_translate_Redmine_in_your_own_language.

Thanks for your contribution.

1 see patch and How_to_create_patch_series_on_Mercurial_and_Git for instructions

#5 Updated by Anton Oslyak 4 months ago

Done!

URL: https://svn.redmine.org/redmine/trunk
revision: 16333

Translated files:

./config/locales/uk.yml
./public/javascripts/jstoolbar/lang/jstoolbar-uk.js
./public/help/uk/wiki_syntax_markdown.html
./public/help/uk/wiki_syntax_textile.html
./public/help/uk/wiki_syntax_detailed_textile.html
./public/help/uk/wiki_syntax_detailed_markdown.html

#6 Updated by Anton Oslyak 4 months ago

Btw,
Inside Ukraine everywhere:

  • national domain .ua
  • at car number plates,
  • at the documents,
  • even in currency sign UAH (Ukrainian hryvnia)

Used UA symbols, not UK

But in my international passport.

Country code: UKR

Even Google translator translate UK from English to Ukrainian as Great Britain

So, I think that correct variant is for two chars UA and for three chars UKR

P.S. But I don't think it has really matter.

#7 Updated by Mischa The Evil 3 months ago

Anton Oslyak wrote:

Done!

URL: https://svn.redmine.org/redmine/trunk
revision: 16333

It seems something went wrong as your patch is reverting r16206, r16207 and r16208. Probably it is not made against current trunk. Can you please fix this?

Anton Oslyak wrote:

Btw,
Inside Ukraine everywhere:

  • national domain .ua
  • at car number plates,
  • at the documents,
  • even in currency sign UAH (Ukrainian hryvnia)

Used UA symbols, not UK

But in my international passport.
[Country code: UKR]

Even Google translator translate UK from English to Ukrainian as Great Britain

So, I think that correct variant is for two chars UA and for three chars UKR

P.S. But I don't think it has really matter.

Well, the international passport seems to use ISO 639-2 for the country code. UA is the official ISO 3166-1 country code whereas uk is the official ISO 639-1 language code.

#8 Updated by Anton Oslyak 3 months ago

Let's break it's in a few steps

First of all I fixed all files exept uk.yml

Please check it

#10 Updated by Mischa The Evil 3 months ago

Anton Oslyak wrote:

  • File ukrainian_localization_without_uk_yml.diff added
  • File ukrainian_localization_without_uk_yml.patch added

First of all I fixed all files exept uk.yml

Please check it

Done, both (they are actually equal besides the extension) apply cleanly onto current trunk @ r16333. I haven't done (and am unable to do) any substantial review of these patches as I'm not a speaker of the respective language, but they 'structurally' look good.

#11 Updated by Anton Oslyak 3 months ago

Yes, files was identical besides the extension

Why when

svn co https://svn.redmine.org/redmine/trunk

I don't see my changes???

And last changes in repository

2017-02-12 16:09:07 +0200

#12 Updated by Toshi MARUYAMA 2 months ago

  • Target version set to 3.4.0

#13 Updated by Toshi MARUYAMA 2 months ago

  • Status changed from New to Closed

Committed in trunk r16410, thanks.

Also available in: Atom PDF