Defect #26393

Error when unchecking all settings on some plugins configurations

Added by Keith Dickmann 3 months ago. Updated 2 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Administration
Target version:3.4.2
Resolution:Fixed Affected version:3.4.1

Description

To Reproduce
1 - install a plugin that only as checkboxes on it settings page (or use uploaded test plugin)
2 - check everything and save
3 - uncheck everything and save
4 - crash

NoMethodError (undefined method `permit!' for nil:NilClass):
app/controllers/settings_controller.rb:70:in `plugin'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'

test_plugin.tar.gz (1.11 KB) Keith Dickmann, 2017-07-10 05:46

Associated revisions

Revision 16812
Added by Jean-Philippe Lang 2 months ago

Don't error when posting empty plugin settings (#26393).

History

#1 Updated by Toshi MARUYAMA 3 months ago

  • Status changed from New to Confirmed
  • Target version set to 3.4.2

#2 Updated by Toshi MARUYAMA 3 months ago

It works on Redmine 3.2 and 3.3.

#3 Updated by Jean-Philippe Lang 2 months ago

  • Subject changed from Plugin settings page exception if uncheck all with checkbox only settings to Error when unchecking all settings on some plugins configurations
  • Category set to Administration
  • Status changed from Confirmed to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fixed in r16812, thanks for pointing this out.

#4 Updated by Jean-Philippe Lang 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF