Feature #26620

Change the text of the submit button on search page from button_submit to label_search

Added by Dmitry Lisichkin about 2 years ago. Updated 9 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Search engine
Target version:4.0.0
Resolution:Fixed

Description

:button_search is more intuitive then :button_submit

fix_button_text.patch Magnifier (542 Bytes) Dmitry Lisichkin, 2017-08-03 17:33

button_search.png (102 KB) Marius BALTEANU, 2018-12-02 16:21

Associated revisions

Revision 17683
Added by Go MAEDA 9 months ago

Change the text of the submit button on search page from button_submit to label_search (#26620).

Patch by Dmitry Lisichkin.

Revision 17684
Added by Go MAEDA 9 months ago

Fix for r17683: s/button_search/label_search/ (#26620).

History

#1 Updated by Toshi MARUYAMA about 2 years ago

  • Status changed from New to Needs feedback

Where is "button_search" defined?
"button_submit" is defined at source:trunk/config/locales/en.yml@16905#L1030 .

#2 Updated by Dmitry Lisichkin about 2 years ago

Sorry, I didn't notice that button_search is not defined in core.
I just try to remove maximum of patches from our plugins=).
Problem that button_submit have translations that not always appropriate in some contexts.
In russian it translated as "Принять" and it looks very strange on search page but looks normal on most of other forms.
So I think was good if button_search would be in core too.

#3 Updated by Toshi MARUYAMA almost 2 years ago

Dmitry Lisichkin wrote:

So I think was good if button_search would be in core too.

Do you think :button_search should be used in only app/views/search/index.html.erb?
In other word, other :button_submit should be kept?

#4 Updated by Toshi MARUYAMA almost 2 years ago

  • Category changed from UI to Translations

#5 Updated by Toshi MARUYAMA almost 2 years ago

What do you think :button_search should be in English en.yml?

#6 Updated by Dmitry Lisichkin almost 2 years ago

Sorry for long response.
Yes I think button_search should be in en.yaml even with only one usage in view.
IMHO "search"-button on search form is much better then "submit"-button.

#7 Updated by Toshi MARUYAMA almost 2 years ago

  • Target version set to 4.1.0

#8 Updated by Go MAEDA 9 months ago

  • Tracker changed from Defect to Feature
  • Subject changed from Wrong text of submit button on search page to Change the text of the submit button on search page from button_submit to label_search
  • Category changed from Translations to Search engine
  • Status changed from Needs feedback to Closed
  • Assignee set to Go MAEDA
  • Target version changed from 4.1.0 to 4.0.0
  • Resolution set to Fixed

Committed. Thank you for improving Redmine.

#9 Updated by Marius BALTEANU 9 months ago

For me, this change generates "translation missing: en.button_search". Please see the below screenshot.

In the existing locales, we have only "label_search". We can use this one (my option) or we need to add the "button_search" to locales.

diff --git a/app/views/search/index.html.erb b/app/views/search/index.html.erb
index 1e80d57..682c11a 100644
--- a/app/views/search/index.html.erb
+++ b/app/views/search/index.html.erb
@@ -32,7 +32,7 @@
 <%= hidden_field_tag 'options', '', :id => 'show-options' %>

 </div>
-<p><%= submit_tag l(:button_submit) %></p>
+<p><%= submit_tag l(:button_search) %></p>
 <% end %>

 <% if @results %>

#10 Updated by Go MAEDA 9 months ago

  • Status changed from Reopened to Closed

Marius BALTEANU wrote:

For me, this change generates "translation missing: en.button_search". Please see the below screenshot.

In the existing locales, we have only "label_search". We can use this one (my option) or we need to add the "button_search" to locales.

Fixed in r17684. Thanks.

I changed button_search to label_search before committing as I wrote in the commit message, but probably I mistakenly reverted the local change and applied original patch again.

Also available in: Atom PDF