Project

General

Profile

Actions

Defect #27333

closed

Switching SCM fails after validation error in "New repository" page

Added by Mizuki ISHIKAWA about 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
SCM
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Steps to reproduce:

  1. Open “New repository” ( /projects/:project_name/repositories/new )
  2. Click the Create button without making any changes.
  3. Change SCM (e.g. "Subversion" to "Git")
    ==> The input form does not change at all. As below.
Incorrect form for 'Git' Correct form for 'Git'

development.log:
There is an error "ActionController::RoutingError (No route matches [GET] "/projects/:project_name/repositories"):".

You can solve the problem by making the following changes.

diff --git a/app/helpers/repositories_helper.rb b/app/helpers/repositories_helper.rb
index 314c0b29b..435041b72 100644
--- a/app/helpers/repositories_helper.rb
+++ b/app/helpers/repositories_helper.rb
@@ -138,7 +138,7 @@ module RepositoriesHelper
     select_tag('repository_scm',
                options_for_select(scm_options, repository.class.name.demodulize),
                :disabled => (repository && !repository.new_record?),
-               :data => {:remote => true, :method => 'get'})
+               :data => {:remote => true, :method => 'get', :url => new_project_repository_path(repository.project)})
   end

   def with_leading_slash(path)

Files

correct_git.png (111 KB) correct_git.png Mizuki ISHIKAWA, 2017-10-31 08:03
incorrect_git.png (112 KB) incorrect_git.png Mizuki ISHIKAWA, 2017-10-31 08:03
Actions #1

Updated by Toshi MARUYAMA almost 7 years ago

  • Status changed from New to Confirmed
  • Target version set to 3.4.4

LGTM.

Actions #2

Updated by Go MAEDA almost 7 years ago

  • Target version changed from 3.4.4 to 3.3.6

Redmine 3.3 also is affected by this issue and the patch can be applied to 3.3-stable cleanly. Setting target version to 3.3.6.

Actions #3

Updated by Go MAEDA almost 7 years ago

  • Subject changed from Switching SCM fail after repository creation fails to Switching SCM fails after validation error in "New repository" page
  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed. Thank you for detecting and fixing this issue.

Actions #4

Updated by Go MAEDA almost 7 years ago

  • Status changed from Resolved to Closed

Merged to stable branches.

Actions

Also available in: Atom PDF