Defect #27780

Attachment sort doesn't work with Unicode

Added by Амир Мусин 10 months ago. Updated 10 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Attachments
Target version:-
Resolution: Affected version:

Description

casecmp method doesn't work with Unicode symbol - https://bugs.ruby-lang.org/issues/14055
decision is to use casecmp? instead of casecmp - https://bugs.ruby-lang.org/issues/12786

attachment.rb.patch Magnifier (404 Bytes) Амир Мусин, 2017-12-11 17:47


Related issues

Related to Redmine - Patch #20369: Use String#casecmp for case insensitive comparison Closed

History

#1 Updated by Toshi MARUYAMA 10 months ago

  • Tracker changed from Patch to Defect
  • Subject changed from Attachment.rb patch to Attachment sort doesn't work with Unicode

#3 Updated by Go MAEDA 10 months ago

Амир Мусин, thank you for reporting the problem and providing the patch.

But the patch needs some improvements because Ruby older than 2.4 don't have casecmp? (https://github.com/ruby/ruby/blob/v2_4_0/NEWS). The upcoming Redmine 4.0.0 supports Ruby 2.2.2 and later (#25538).

#4 Updated by Go MAEDA 10 months ago

  • Related to Patch #20369: Use String#casecmp for case insensitive comparison added

Also available in: Atom PDF