Patch #27963
Remove 'unloadable' from bundled sample plugin
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Plugin API | |||
| Target version: | 3.4.5 |
Description
Pretty straightforward. After #20513, the statement should be removed from the bundled example plugin too (i.e. r1282 should be reverted). The following raw patch (against source:/trunk@17169) takes care of this:
Index: extra/sample_plugin/app/controllers/example_controller.rb
===================================================================
--- extra/sample_plugin/app/controllers/example_controller.rb (revision 17169)
+++ extra/sample_plugin/app/controllers/example_controller.rb (working copy)
@@ -1,7 +1,5 @@
# Sample plugin controller
class ExampleController < ApplicationController
- unloadable
-
layout 'base'
before_action :find_project, :authorize
menu_item :sample_plugin
Related issues
Associated revisions
Remove 'unloadable' from bundled sample plugin (#27963).
Patch by Mischa The Evil.
History
#1
Updated by Mischa The Evil about 1 year ago
- Related to Defect #20513: Unloadable plugin convention breaks with Rails 4.2.3 added
#2
Updated by Go MAEDA about 1 year ago
- Status changed from New to Resolved
- Assignee set to Go MAEDA
- Target version set to 3.4.5
Committed to the trunk. Thank you for pointing it out.
#3
Updated by Go MAEDA about 1 year ago
- Status changed from Resolved to Closed
Merged to 3.4-stable.