Patch #28168

Allow context-menu edit of % done and priority of parent issues if the fields are not derived

Added by Holger Just 5 months ago. Updated 5 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Issues
Target version:3.3.7

Description

Following #27533, r17129 implemented a change to not check anymore whether all selected issues for a context-menu can be assigned a priority. This change however is incorrect and incomplete unfortunately.

The check to disable setting of the priority (and similarly but missed in #27533: setting the % done field) was originally done in the view there since originally, the priority and %done fields were always derived from child issues. That is, parent issues always had the highest priority of any of their child issues and a average % done. Later, Redmine gained the ability to configure whether the priority and % done fields should be derived on parent issues or should be settable on their own.

The patch, as it was comitted in r17129 unfortunately fails to check whether the priority field can indeed not be set because the priority field is derived). In that case, the context-menu options should still be disabled. In any case, the same issue also is present for the % done field and is there still unhandled completely.

The attached patch against current trunk (at r17192) fixes and unifies the behavior for both fields.

0001-Allow-context-menu-edit-of-done-and-priority-of-pare.patch Magnifier (1.67 KB) Holger Just, 2018-02-09 15:45


Related issues

Related to Redmine - Defect #27533: Cannot change the priority of the parent issue in issue q... Closed

Associated revisions

Revision 17204
Added by Go MAEDA 5 months ago

Allow context-menu edit of % done and priority of parent issues if the fields are not derived (#28168).

Patch by Holger Just.

Revision 17205
Added by Go MAEDA 5 months ago

Merged r17204 from trunk to 3.4-stable (#28168).

Revision 17206
Added by Go MAEDA 5 months ago

Merged r17204 from trunk to 3.3-stable (#28168).

History

#1 Updated by Go MAEDA 5 months ago

  • Related to Defect #27533: Cannot change the priority of the parent issue in issue query context menu when parent priority is independent of children added

#2 Updated by Go MAEDA 5 months ago

  • Target version set to 3.3.7

#3 Updated by Go MAEDA 5 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed.
Thank you for fixing this issue.

Also available in: Atom PDF