Project

General

Profile

Actions
Copy link

Defect #28636

closed

Cannot find an issue from a closed subproject when search scope is Project and its subprojects

Added by Rene Sperling almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Search engine
Target version:
3.4.7
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
3.3.8

Description

Hi,

I have a main project with several closed subprojets. I want to find an issue from one of these closed projects.
Using the search function with 'project with subprojects' Redmine does not list it.
When using 'all projects' or reopening the concerning project Redmine shows the issue.

If this is not a bug, it would be nice to have an option to switch that behavior off.

Files

0001-Include-closed-projects-in-search-for-scope-subproje.patch (2.49 KB) 0001-Include-closed-projects-in-search-for-scope-subproje.patch Marius BĂLTEANU, 2018-12-06 07:44
Actions
Copy link
 #1

Updated by zhangzhi liao over 5 years ago

+1

Actions
Copy link
 #2

Updated by Marius BĂLTEANU over 5 years ago

  • Category changed from Issues list to Search engine
  • Status changed from New to Confirmed

Confirmed the problem.

Scope 'subprojects' is the only scope that searches only in the active projects. Scopes 'all' and 'my projects' include also closed projects. I think we should be consistent with the behaviour between the search scopes. At the same time, maybe it is a good idea to have an option in the search page to include only active projects in the search (how we have for the issues).

Actions
Copy link
 #3

Updated by Go MAEDA over 5 years ago

I agree with Marius' opinion. Jean-Philippe wrote in #6049#note-9 as follows. It is obvious that closed subprojects should be searchable.

I'm closing this request since 2.1.0 adds the ability to close projects. Closed projects are still visible/searchable but read-only.

Actions
Copy link
 #4

Updated by Marius BĂLTEANU over 5 years ago

  • Assignee set to Marius BĂLTEANU
Actions
Copy link
 #5

Updated by Marius BĂLTEANU over 5 years ago

Attached the patch. I think we can include this fix in 3.4.7 or 3.3.9.

All tests pass: https://gitlab.com/marius-balteanu/redmine/pipelines/39107412

Actions
Copy link
 #6

Updated by Marius BĂLTEANU over 5 years ago

  • Subject changed from Cannot find an issue from a closed subproject to Cannot find an issue from a closed subproject when search scope is Project and its subprojects
Actions
Copy link
 #7

Updated by Go MAEDA over 5 years ago

  • Target version changed from Candidate for next minor release to 3.3.9
  • Affected version changed from 3.4.5 to 3.3.8

LGTM. Setting the target version to 3.3.9.

Actions
Copy link
 #8

Updated by Go MAEDA over 5 years ago

  • Status changed from Confirmed to Closed
  • Assignee changed from Marius BĂLTEANU to Go MAEDA
  • Target version changed from 3.3.9 to 3.4.7
  • Resolution set to Fixed

Committed the patch. Thank you for catching and fixing this issue.

I didn't commit the fix to 3.3-stable branch because a test failed.

$ ruby test/functional/search_controller_test.rb
Run options: --seed 17373

# Running:

...............................F.

Finished in 7.689243s, 4.2917 runs/s, 14.1756 assertions/s.

  1) Failure:
SearchControllerTest#test_search_should_include_closed_projects [test/functional/search_controller_test.rb:302]:
Expected at least 1 element matching "#search-results", found 0..
Expected 0 to be >= 1.

33 runs, 109 assertions, 1 failures, 0 errors, 0 skips
Actions
Copy link

Also available in: Atom PDF