Patch #30177

Thumbnail lifecycle: reuse thumbs from identical files, delete thumbs when diskfile is deleted

Added by Jens Krämer about 1 month ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Attachments
Target version:4.1.0

Description

These patches improve thumbnail handling in two aspects:

  • By changing the naming scheme for thumbnails to not use the attachment ID anymore, already generated thumbnails for identical attachments will be reused.
  • The second patch adds code to remove any thumbnails when the original attachment file is deleted from disk. Without this patch, thumbnails of deleted attachments are never deleted.

0001-allows-re-use-of-thumbnails-for-identical-attachment.patch Magnifier (2.64 KB) Jens Krämer, 2018-12-11 08:49

0002-deletes-thumbnails-when-the-attachment-diskfile-is-d.patch Magnifier (2.4 KB) Jens Krämer, 2018-12-11 08:49

Associated revisions

Revision 17735
Added by Go MAEDA about 1 month ago

Allows re-use of thumbnails for identical attachments (#30177).

Patch by Jens Krämer.

Revision 17736
Added by Go MAEDA about 1 month ago

Deletes thumbnails when the attachment diskfile is deleted (#30177).

Patch by Jens Krämer.

History

#1 Updated by Go MAEDA about 1 month ago

  • Target version set to Candidate for next major release

#2 Updated by Go MAEDA about 1 month ago

  • Target version changed from Candidate for next major release to 4.1.0

LGTM. We can save disk space with this patch. Setting the target version to 4.1.0.

#3 Updated by Go MAEDA about 1 month ago

  • Assignee set to Go MAEDA

#4 Updated by Go MAEDA about 1 month ago

  • Status changed from New to Closed

Committed the patches. Thank you for improving Redmine.

Also available in: Atom PDF