Defect #30259

URLs end with "-" are rendered incorrectly in Textile

Added by Hirofumi Kadoya 9 months ago. Updated 7 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Text formatting
Target version:4.1.0
Resolution:Fixed Affected version:

Description

Last character "-" makes wrong link
please add link "-" character

for example googledrive use "-"
--

ja---

概要、説明、注記等で、URLリンクの最後の文字が "-"だった場合
リンク扱いとならず、誤ったリンクとなる
グーグルドライブなどは、最終文字が "-" となることがあり、修正してほしいです

画像も参照してください

Screenshot 2018-12-21 at 16.30.09 - Display 1.png (21.8 KB) Hirofumi Kadoya, 2018-12-21 08:31

0001-Remove-unnecessary-trailing-white-spaces.patch Magnifier (23.6 KB) Yuichi HARADA, 2019-01-08 09:07

0002-Interpret-trailing-hyphens-as-URL.patch Magnifier (4.29 KB) Yuichi HARADA, 2019-01-08 09:07

output.trailing.special.characters.png (12.6 KB) Guillermo ML, 2019-01-10 14:32

Associated revisions

Revision 17917
Added by Go MAEDA 7 months ago

URLs end with "-" are rendered incorrectly in Textile (#30259).

Patch by Yuichi HARADA.

History

#1 Updated by Go MAEDA 9 months ago

  • Subject changed from Last character "-" makes wrong link to URLs end with "-" are rendered incorrectly in Textile
  • Description updated (diff)
  • Category set to Text formatting
  • Status changed from New to Confirmed

confirmed the problem. This issue is reproducible in Textile. Markdown is not affected.

Input:

http://example.com/foo-

Expected output:

<a class="external" href="http://example.com/foo-">http://example.com/foo-</a>

Actual output:

<a class="external" href="http://example.com/foo">http://example.com/foo</a>-

#2 Updated by Yuichi HARADA 9 months ago

I reviewed the regular expression to interpret the trailing hyphens as URL.
I attached patches.

#3 Updated by Go MAEDA 9 months ago

  • Target version set to Candidate for next minor release

#4 Updated by Guillermo ML 9 months ago

Same with ?, &, # and $ characters. These URL:

https://example.org/ticket.form.php?id=333?
https://example.org/ticket.form.php?id=333&
https://example.org/TicketID=455#
https://example.org/TicketID=455$

will be rendered (3.4.4.stable) as:

For example the second link could be generated by glpi tool and the third one is sometimes generated by otrs tool. I think all four are valid characters at the end of an URL.

#5 Updated by Go MAEDA 7 months ago

  • Target version changed from Candidate for next minor release to 4.0.2

Setting the target version to 4.0.2.

#6 Updated by Go MAEDA 7 months ago

  • Target version changed from 4.0.2 to 4.1.0

#7 Updated by Go MAEDA 7 months ago

  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you all for reporting and fixing this issue.

Also available in: Atom PDF