Defect #30426

Table rows are not highlighted on mouseover on some pages

Added by VD DV about 1 month ago. Updated 29 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:3.4.8
Resolution:Fixed Affected version:3.4.7

Description

I am testing redmine v4.0.0 and discovered that hovering on some pages does not work.
Till now I discovered that problem on:
- .../projects/ProjectName/settings/activities
- .../admin/projects
- .../users
- .../groups
- .../roles
- .../trackers
and so on....

With hovering I mean: when mouse pointer is over some row on table, whole row is highlited (yellow like in version e.g 2.3).

Without hovering, it is realy difficult to not to make mistake while selecting action on far right on that row, while row label is on the far left.

undesirable-highlighting-in-issues-list@2x.png (22.8 KB) Go MAEDA, 2019-01-17 01:35

fix_30426.patch Magnifier (1.13 KB) Marius BALTEANU, 2019-01-17 20:34

Associated revisions

Revision 17800
Added by Go MAEDA about 1 month ago

Table rows are not highlighted on mouseover on some pages (#30426).

Patch by Marius BALTEANU.

Revision 17801
Added by Go MAEDA about 1 month ago

Merged r17800 from trunk to 4.0-stable (#30426).

Revision 17802
Added by Go MAEDA about 1 month ago

Merged r17800 from trunk to 3.4-stable (#30426).

Revision 17803
Added by Go MAEDA about 1 month ago

Reverted r17800 (#30426).

Undesirable behavior in the issues list.

Revision 17804
Added by Go MAEDA about 1 month ago

Merged r17803 from trunk to 4.0-stable in order to revert r17801 (#30426).

Revision 17805
Added by Go MAEDA about 1 month ago

Merged r17803 from trunk to 3.4-stable in order to revert r17802 (#30426).

Revision 17806
Added by Go MAEDA 29 days ago

Table rows are not highlighted on mouseover on some pages (#30426).

Patch by Marius BALTEANU.

Revision 17807
Added by Go MAEDA 29 days ago

Merged r17806 from trunk to 4.0-stable (#30426).

Revision 17808
Added by Go MAEDA 29 days ago

Merged r17806 from trunk to 3.4-stable (#30426).

History

#1 Updated by Go MAEDA about 1 month ago

  • Status changed from New to Confirmed
  • Target version set to Candidate for next minor release
  • Affected version changed from 4.0.0 to 3.4.7

Confirmed the problem in 3.4.7 and 4.0.0. No problem was found in 3.3.9.

#2 Updated by Marius BALTEANU about 1 month ago

  • Target version changed from Candidate for next minor release to 3.4.8

The fix is quite simple:

diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index fa59d6a..80defce 100644
--- a/public/stylesheets/application.css
+++ b/public/stylesheets/application.css
@@ -352,13 +352,13 @@ tr.group a.toggle-all { color: #aaa; font-size: 80%; display:none; float:right;
 tr.group:hover a.toggle-all { display:inline;}
 a.toggle-all:hover {text-decoration:none;}

-table.list tbody tr:hover { background-color:#ffffdd; }
-table.list tbody tr.group:hover { background-color:inherit; }
 table td {padding:2px;}
 table p {margin:0;}

 table.list:not(.odd-even) tbody tr:nth-child(odd), .odd, #issue-changesets div.changeset:nth-child(odd) { background-color:#f6f7f8; }
 table.list:not(.odd-even) tbody tr:nth-child(even), .even, #issue-changesets div.changeset:nth-child(even) { background-color: #fff; }
+table.list tbody tr:hover { background-color:#ffffdd !important; }
+table.list tbody tr.group:hover { background-color:inherit !important; }

 tr.builtin td.name {font-style:italic;}

Even if I'm not a fan of "!important", I think that in this case it is ok to use it.

#3 Updated by VD DV about 1 month ago

Is same fix applicable to v4.0.0? If not, can you provide fixed file (I assume it is only application.css), to upload to v4.0.0 redmine installation?

#4 Updated by Marius BALTEANU about 1 month ago

VD DV wrote:

Is same fix applicable to v4.0.0? If not, can you provide fixed file (I assume it is only application.css), to upload to v4.0.0 redmine installation?

Yes, it is.

#5 Updated by Go MAEDA about 1 month ago

  • Subject changed from Hovering on most pages does not work as before to Table rows are not highlighted on mouseover on some pages

#6 Updated by Go MAEDA about 1 month ago

  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you all for reporting and fixing this issue.

VD DV wrote:

Is same fix applicable to v4.0.0? If not, can you provide fixed file (I assume it is only application.css), to upload to v4.0.0 redmine installation?

Please replace application.css with https://www.redmine.org/projects/redmine/repository/revisions/17801/raw/branches/4.0-stable/public/stylesheets/application.css.

#7 Updated by Go MAEDA about 1 month ago

The change r17800 caused undesirable behavior in the issues list. Multiple selected issues are also highlighted on mouseover, so you can not read the text.

I will revert the change.

#8 Updated by Marius BALTEANU about 1 month ago

Go MAEDA wrote:

The change r17800 caused undesirable behavior in the issues list. Multiple selected issues are also highlighted on mouseover, so you can not read the text.

I will revert the change.

Sorry, I’ll rewrite the fix.

#9 Updated by Marius BALTEANU 30 days ago

Attached a better fix. I've checked both scenarios and it works well.

Sorry for my previous fix and a note to myself: "!important is never safe"

#10 Updated by Go MAEDA 29 days ago

  • Status changed from Reopened to Resolved

Marius BALTEANU wrote:

Attached a better fix. I've checked both scenarios and it works well.

Committed. Thanks!

a note to myself: "!important is never safe"

I must not forget this, too.

#11 Updated by Go MAEDA 29 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF